-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New feat : Upload image in torrent upload page & torrent detail #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
config.js was mounted as a folder and not a file ^^
front-end to back-end with upload system => OK back-end to db from api => OK
just english ok
Feat/french locale
Feat/torrent upload image
tdjsnelling
requested changes
Oct 12, 2023
CamelCase & alphabetical order
Poster => Cover image
… code following the comments made on the Pull request
Fix to make cover image not required. and optimization of my personal…
All done. |
Any ETA on this push? |
Also looking at an update on a potential push. |
Sorry for the delay. Thanks for your changes, everything looks good now. Good job getting this implemented |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this update, here are the points that have been modified/added:
Fixed a Docker bug that prevented the correct mounting of the config.js file with Docker by explicitly indicating that it is a file and not a directory.
Added the image upload functionality requested in this report:
link to the report
Also visible on the torrent detail page.
Added the French locales.