Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider wheels #42

Closed
wants to merge 1 commit into from
Closed

consider wheels #42

wants to merge 1 commit into from

Conversation

Kriechi
Copy link

@Kriechi Kriechi commented Feb 22, 2017

Many pypi packages only uploaded wheels, which poet doesn't consider.
This PR makes a small change to also accept wheels as artifact.

fixes #29

@tdsmith
Copy link
Owner

tdsmith commented Feb 22, 2017

Can you give an example of a package that doesn't distribute an sdist? I don't think there are "many".

Copy link
Owner

@tdsmith tdsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Homebrew-pypi-poet must not consider wheels with binary content; this should do tag matching on the filename to make sure it's a pure python wheel.

@tdsmith
Copy link
Owner

tdsmith commented Feb 22, 2017

This isn't sufficient to resolve #29; some packages have entries on pypi but no uploaded distributions.

@Kriechi
Copy link
Author

Kriechi commented Feb 22, 2017

I'm one of the @mitmproxy maintainers, and we only ship wheels, because otherwise we run into problems with Python2 installations.

So I know of mitmproxy and one of our dependencies: construct.

@jbarlow83
Copy link

Python wheels should be the first choice and sdist should be the fallback.

Why not consider macOS binary wheels? People regularly install Homebrew and pip binaries.

@tdsmith
Copy link
Owner

tdsmith commented Feb 28, 2017

Why not consider macOS binary wheels?

Homebrew policy (and therefore poet's policy) is to build from source.

Pure-python wheels are technically a distribution format and not a source format but the distinction feels less important and it might simplify things at some future point where setuptools is less dominant so I feel less strongly about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

poet crashes if no sdist available
3 participants