-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add serializability #76
Comments
I would be very interested in pull requests.
…On Wed, Nov 30, 2016 at 12:24 AM, Carl Düvel ***@***.***> wrote:
We use a patched version of t-digest because we have to send AVLTreeDigest
over the wire (because we are using spark) and therefore the class has to
be serializable. Would you be open to merge this as a pull request? If so
we would provide one.
Btw. thx for this awesome library - saves us a ton of time computing
percentiles!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#76>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAPSegJP35fi5XgY8HAW9sQsiggHSXT4ks5rDEOtgaJpZM4K_GUW>
.
|
You are totally right. |
Agree.
I have been working on the branches faster-merge and new-article to get to
where a release will work.
The upshot will be much faster implementation and better accuracy. Also, a
different technology histogram as well. And serializability.
…On Thu, Dec 22, 2016 at 2:08 AM, Alexander Oleinikov < ***@***.***> wrote:
Since f4ed7af
<f4ed7af>
TDigest is already implements Serializable, which should be enough for
Spark.
I guess the only piece which is missing is to release the code (#67
<#67>)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#76 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAPSetbb4PQRIehZN-EiKzbyy9z7q4TWks5rKkwLgaJpZM4K_GUW>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We use a patched version of t-digest because we have to send AVLTreeDigest over the wire (because we are using spark) and therefore the class has to be serializable. Would you be open to merge this as a pull request? If so we would provide one.
Btw. thx for this awesome library - saves us a ton of time computing percentiles!
The text was updated successfully, but these errors were encountered: