Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper icon and app screenshot #3

Open
1 of 2 tasks
te-online opened this issue Sep 21, 2017 · 10 comments
Open
1 of 2 tasks

Add proper icon and app screenshot #3

te-online opened this issue Sep 21, 2017 · 10 comments
Labels

Comments

@te-online
Copy link
Owner

te-online commented Sep 21, 2017

Todo

  • Add icon
  • Add app screenshot
@DJCrashdummy
Copy link
Contributor

just my 2 cents:
at least for now the globe used as file-icon is quite ok... it just needs to be added as app-icon.

@te-online te-online changed the title Add proper icon Add proper icon and app screenshot Mar 8, 2018
te-online pushed a commit that referenced this issue Aug 31, 2019
* Add files via upload

* Update info.xml

update description with emoji's and screenshot
@Shen
Copy link

Shen commented Nov 9, 2019

Currently there is shown a gearwheel if I add a link. Is it possible to change this to a globe- or link-symbol?

@te-online
Copy link
Owner Author

te-online commented Nov 10, 2019

In the appstore, you mean? Yeah, it could be nice to have an SVG globe there. Would you mind looking for the icon in github.com/nextcloud/server and then create a PR to add the icon so the appstore can read it? (For inspiration I'd look at how other apps do it). 😊

Edit: It's probably a line in appinfo/info.xml.

@Shen
Copy link

Shen commented Nov 10, 2019

No, if I create a new Link in Files-App.
8851A25F-91E9-456D-A455-BDC006191483

@te-online
Copy link
Owner Author

@Shen Is this screenshot taken from the web interface of Nextcloud? I can't reproduce the wrong icon in version 16 or 17 🤔 For me it shows the globe.
Bildschirmfoto 2019-11-11 um 21 26 27

@Shen
Copy link

Shen commented Dec 6, 2019

Yes, it is from the web interface of Nextcloud (16.0.5.1). Strange...

@te-online
Copy link
Owner Author

Sorry that I can't say what's wrong...

Maybe you can right-click the icon and click “Inspect element“, then paste a screenshot of that HTML node here?

I'm guessing that maybe another app is interfering or something like that?

@Shen
Copy link

Shen commented Jan 9, 2020

Something like this?
linkeditor-icon-bug

@te-online
Copy link
Owner Author

I have a suspicion that this has to do with the “Theming” app. Let me look into this once I get a bit of time... Sorry for the delay!

@te-online
Copy link
Owner Author

te-online commented Feb 13, 2020

@Shen Can you check if you even have the correct icon file at /index.php/apps/theming/img/core/filetypes/link.svg?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants