Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/reporter #142

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Feature/reporter #142

wants to merge 13 commits into from

Conversation

DavidProdinger
Copy link

Reporting

  • Add an administration settings section for timemanager
  • Add a setting to select a group as Reporter. The memebers can view all Clients/Entries in the reports tab
    • Also moved your existing (but hidden) conflict handling setting there

Note: This PR is based on the group sharing feature #141

@te-online
Copy link
Owner

@DavidProdinger Thanks for this contribution 🙌

Some short feedback:

  • Please merge main into this branch at your next convenience 😊
  • The conflict handling setting should probably be removed as it doesn't make as much sense as I initially thought, sorry you had extra work with this
  • I'm not sure yet how to handle this best and if an extra admin section for just this one setting is a good idea. I will think about this a bit and get back to you 🤓

@DavidProdinger
Copy link
Author

@te-online
Thanks for the feedback and merging the other 🙌

  • merged
  • since it was there, I just copied it to the settings...
  • Settings, it might be a little bit overpowered, but you can put a "Transfer Client" or global client function 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DavidProdinger @te-online