Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #88 #92

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -102,5 +102,8 @@
"react-test-renderer": "17.0.2",
"shelljs": "0.8.4"
},
"bugs": "https://github.com/teafuljs/teaful/issues"
"bugs": "https://github.com/teafuljs/teaful/issues",
"dependencies": {
"use-sync-external-store": "^1.2.0"
}
}
1 change: 1 addition & 0 deletions package/index.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import {useEffect, useReducer, createElement} from 'react';
import {useSyncExternalStore} from 'use-sync-external-store/shim';

let MODE_GET = 1;
let MODE_USE = 2;
Expand Down
2 changes: 1 addition & 1 deletion tests/getStore.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -134,5 +134,5 @@ describe('getStore', () => {
expect(screen.getByTestId('items').textContent).toContain('firstElement');
act(() => push(items, 'secondElement'));
expect(screen.getByTestId('items').textContent).toContain('firstElement,secondElement');
})
});
});
65 changes: 65 additions & 0 deletions tests/issue88.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
import {render} from '@testing-library/react';
import {useEffect, useState} from 'react';

import '@babel/polyfill';

import createStore from '../package/index';

describe('Issue 88', () => {
it('should subscribe even if initially not rendered', () => {
const track = jest.fn();

const initialStore = {
number: 0,
};
const {useStore} = createStore(initialStore);

const AA = () => {
const [number] = useStore.number();
track(`AA number: ${number}`);

return number;
};

const CC = () => {
const [number, setNumber] = useStore.number();
track(`CC number: ${number}`);
if (!number) {
setNumber((prev) => prev + 1);
}

return 'c';
};

function App() {
const [show, setShow] = useState(false);
track(`App show: ${show}`);
useEffect(() => {
setShow(true);
}, []);

return (
<div>
{show && (
<>
<AA />
<CC />
</>
)}
</div>
);
}

render(<App />);

console.log(track.mock.calls);
expect(track.mock.calls).toContain([
[ 'App show: false' ],
[ 'App show: true' ],
[ 'AA number: 0' ],
[ 'CC number: 0' ],
[ 'AA number: 1' ],
[ 'CC number: 1' ],
]);
});
});
5 changes: 5 additions & 0 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -5586,6 +5586,11 @@ uri-js@^4.2.2:
dependencies:
punycode "^2.1.0"

use-sync-external-store@^1.2.0:
version "1.2.0"
resolved "https://registry.yarnpkg.com/use-sync-external-store/-/use-sync-external-store-1.2.0.tgz#7dbefd6ef3fe4e767a0cf5d7287aacfb5846928a"
integrity sha512-eEgnFxGQ1Ife9bzYs6VLi8/4X6CObHMw9Qr9tPY43iKwsPw8xE8+EFsf/2cFZ5S3esXgpWgtSCtLNS41F+sKPA==

util-deprecate@^1.0.2:
version "1.0.2"
resolved "https://registry.yarnpkg.com/util-deprecate/-/util-deprecate-1.0.2.tgz#450d4dc9fa70de732762fbd2d4a28981419a0ccf"
Expand Down