Send all progress logging messages to stderr. #171
Conversation
|
To keep this consistent with the rest of the program, messages like "Successfully deleted cache." should also be printed on stderr. Maybe even the "page not found" output, but I am not sure about that one. (@dbrgn ?) @dmaahs2017 As you can see, the tests have to be updated accordingly, but that should be a quick fix |
dmaahs2017
changed the title
dmaahs2017
changed the title
dmaahs2017
changed the title
There was a problem hiding this comment.
This is a good thing to do (no matter how we handle the paging issue). However, the tests need an update (expect the string in stderr, not stdout).
@dmaahs2017 can you update the tests as well?
- updated tests to expect these messages in stderr instead of stdout - changed test_markdown_rendering to no longer rely on the tldr pages repo. Instead manually adding a known page to use in this test, because it failed due to the tldr pages repo updating this command (so it no longer matched our expected output, which shouldn't cause our tests to fail).
dmaahs2017
changed the title
dmaahs2017
changed the title
|
Ready for re-review. @niklasmohrin @dbrgn. I grepped the src files for all the |
dmaahs2017
changed the title
| .assert() | ||
| .success() | ||
| .stdout(contains("Successfully updated cache.")); | ||
| testenv.add_entry("tar", include_str!("tar-markdown.expected")); |
Adresses #169.
repo. Instead manually adding a known page to use in this test,
because it failed due to the tldr pages repo updating this command (so
it no longer matched our expected output, which shouldn't cause our
tests to fail).