Update CI workflows #324

kbdharun · 2023-05-10T12:53:01Z

Changes

Remove unmaintained rust actions and use the components directly in the GitHub action runners.
Update runners.
Update toolchain to https://github.com/dtolnay/rust-toolchain.
Bump the actions/checkout version to v3 (Node 16).
Bump the actions/upload-artifact version to v3 (Node 16).
Bump the actions/download-artifact version to v3 (Node 16).

niklasmohrin · 2023-05-11T07:01:21Z

Hi :) These changes seem nice, but they make it a bit intransparent as to what versions are used. For example, I dont see which version of the rust compiler is running (and we also want to build with two specific versions: the msrv and stable). About the OS update: not sure either, but should probably be fine

kbdharun · 2023-05-12T14:47:30Z

Hi :) These changes seem nice, but they make it a bit intransparent as to what versions are used. For example, I don't see which version of the rust compiler is running (and we also want to build with two specific versions: the msrv and stable).

Sorry for the delay, I wasn't feeling well. I have updated the workflow now to support multiple versions of Rust, a test action run can be found here [Note: the failed actions are because I am running it in a fork, it should run fine here, also by the way can you approve the workflow run]

About the OS update: not sure either, but it should probably be fine

Yep, it is better to use the latest stable versions to have faster CIs and additional features. Let me know If you guys need me to revert it.

niklasmohrin · 2023-05-29T17:20:56Z

Hi, I think it is still not correct: You have added the line back in that starts more CI runs with different values for the rust variable, but this variable is never used (note the use of ${{ matrix.rust }} before when installing the toolchain). Currently, it is still the preinstalled version of Rust that is used, which is not what we want for the reasons I wrote before.

I was unaware that actions-rs is not maintained anymore, so switching to something else seems like a good idea. From what I can tell from actions-rs/toolchain#216 and for example jonhoo/rust-ci-conf@362696a the world is moving to dtolnay's action, so I think going with that would be a sane move :)

Note: the failed actions are because I am running it in a fork

Actually, I think that you forgot to add the checkout action back in in the two jobs that are failing as both fail because of a missing Cargo.toml file :)

About using latest os, I was wondering if we would maybe want to stay with the older versions so that we don't miss an incompatibility with for example windows 10, ubuntu 22.04 or so. @dbrgn what do you think about this?

kbdharun · 2023-05-30T17:22:12Z

Hi, I think it is still not correct: You have added the line back in that starts more CI runs with different values for the rust variable, but this variable is never used (note the use of ${{ matrix.rust }} before when installing the toolchain). Currently, it is still the preinstalled version of Rust that is used, which is not what we want for the reasons I wrote before.

Noted

I was unaware that actions-rs is not maintained anymore, so switching to something else seems like a good idea. From what I can tell from actions-rs/toolchain#216 and for example jonhoo/rust-ci-conf@362696a the world is moving to dtolnay's action, so I think going with that would be a sane move :)

Agreed, I will try to update this PR to https://github.com/dtolnay/rust-toolchain as even with matrix jobs it is possible for some old versions of packages to be dropped from runner images i.e https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2204-Readme.md.

Note: the failed actions are because I am running it in a fork

Actually, I think that you forgot to add the checkout action back in in the two jobs that are failing as both fail because of a missing Cargo.toml file :)

Oops, just now noticed it will fix it.

About using latest os, I was wondering if we would maybe want to stay with the older versions so that we don't miss an incompatibility with for example windows 10, ubuntu 22.04 or so. @dbrgn what do you think about this?

Regarding this, the official GitHub runner doesn't support Windows 10 runners while the ubuntu-latest runner is the latest LTS Ubuntu version which is 22.04 now. Do note if you need I could add Ubuntu 20.04 to tests but the runner will get removed next year when 24.04 gets released as GitHub only keeps 2 LTS versions of Ubuntu runners at a time. An alternative is running the job in a container (as GitHub self-hosted runners aren't advisable for public projects)

Edit. Done updated the CI to the suggested toolchain action, and all jobs have succeeded https://github.com/kbdharun/tealdeer/actions/runs/5124671837 (as requested I added an older supported runner for Ubuntu 20.04)

* CI: Update to dtolnay/rust-toolchain, fix checkout * CI: update toolchain version to 1.62.1 * CI: update toolchain as matrix job

niklasmohrin

Alright, some more comments before we can merge this :)

.github/workflows/ci.yml

niklasmohrin · 2023-07-05T21:41:01Z

.github/workflows/ci.yml

-      - uses: actions-rs/toolchain@v1
-        with:
-          toolchain: stable
-          profile: minimal
-          default: true


There is no corresponding use of dtolnay/rust-toolchain for this use of actions-rs/toolchain

I think the general one is fine in this case as it doesn't impact the time taken by the CI.

.github/workflows/release.yml

kbdharun

GitHub actions runners have cargo and rustfmt builtin. As per your request, I will add the toolchain action for those use cases too.

.github/workflows/ci.yml

.github/workflows/release.yml

kbdharun · 2023-07-06T04:56:09Z

.github/workflows/ci.yml

-      - uses: actions-rs/toolchain@v1
-        with:
-          toolchain: stable
-          profile: minimal
-          default: true


I think the general one is fine in this case as it doesn't impact the time taken by the CI.

.github/workflows/ci.yml

.github/workflows/release.yml

kbdharun · 2023-07-06T07:22:44Z

Done, I think it is GTG now.

dbrgn · 2023-07-06T19:36:01Z

This looks good to me, let's see if CI runs through! If yes, I think we can merge this.

Thanks for your work and your patience, @kbdharun and @niklasmohrin 🙂

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [dbrgn/tealdeer](https://github.com/dbrgn/tealdeer) | minor | `v1.6.1` -> `v1.7.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>dbrgn/tealdeer (dbrgn/tealdeer)</summary> ### [`v1.7.0`](https://github.com/dbrgn/tealdeer/blob/HEAD/CHANGELOG.md#v170-v170-2024-10-02) [Compare Source](tealdeer-rs/tealdeer@v1.6.1...v1.7.0) It's been 24 months since the last release, time for tealdeer 1.7.0! Thanks to 16 individual contributors, a few nice changes and features are included in this release. One change is that you can **query multiple platforms at once**. For example: tldr --platform openbsd --platform linux df This will show the `df` page for OpenBSD (if available), followed by Linux (if available), with fallback to the current platform on which tealdeer runs. What's that `openbsd` thing up there? Yes, there's now **support for the BSD platforms `freebsd`, `netbsd` and `openbsd`**. And since we're already talking about platform support: Our **binary releases now include builds for ARM64 (aka `aarch64`) on macOS (Apple Silicon, M1/M2/M3) and Linux**. *(Keep in mind that binary releases are generated in CI and are unsigned. For a trusted build, please compile from source.)* There's also a breaking change for the folks using [custom pages and patches](https://tealdeer-rs.github.io/tealdeer/usage_custom_pages.html): These files now use a `.md` extension. Old files will continue to work, but will result a deprecation warning being printed when used. On a personal note, this will be the last release from me ([Danilo](https://github.com/dbrgn/)) as primary maintainer of tealdeer. For details, see [#376](tealdeer-rs/tealdeer#376). Changes: - \[added] Allow querying multiple platforms (\[[#300](tealdeer-rs/tealdeer#300)]) - \[added] Add BSD platform support (\[[#354](tealdeer-rs/tealdeer#354)]) - \[added] Allow building with native-tls in addition to rustls (\[[#303](tealdeer-rs/tealdeer#303)]) - \[changed] Change custom page files to use a `.md` file extension (\[[#322](tealdeer-rs/tealdeer#322)]) - \[changed] Update to clap v4 for doing command line parsing (\[[#298](tealdeer-rs/tealdeer#298)]) - \[changed] Performance optimization in LineIterator (\[[#314](tealdeer-rs/tealdeer#314)]) - \[changed] Performance optimizations by tweaking Cargo flags (\[[#355](tealdeer-rs/tealdeer#355)]) - \[changed] Include completions in published crate (\[[#333](tealdeer-rs/tealdeer#333)]) - \[changed] Minimal supported Rust version is now 1.75 (\[[#298](tealdeer-rs/tealdeer#298)]) - \[fixed] Fix bash/zsh/fish completions when cache is empty (\[[#327](tealdeer-rs/tealdeer#327)], \[[#331](tealdeer-rs/tealdeer#331)]) - \[docs] Publish docs only when tagging a release (\[[#362](tealdeer-rs/tealdeer#362)]) - \[docs] List Scoop and Debian packages (\[[#305](tealdeer-rs/tealdeer#305)], \[[#315](tealdeer-rs/tealdeer#315)]) - \[docs] Add "Tips and Tricks" chapter to user manual (\[[#342](tealdeer-rs/tealdeer#342)]) - \[docs] Various docs improvements (\[[#293](tealdeer-rs/tealdeer#293)]) - \[chore] Improvements to CI workflows (\[[#324](tealdeer-rs/tealdeer#324)]) - \[chore] Update Cargo.toml license field following SPDX 2.1 (\[[#336](tealdeer-rs/tealdeer#336)]) - \[chore] Dependency updates Contributors to this version: - \[Adam Henley]\[[@adamazing](https://github.com/adamazing)] - \[Andrea Frigido]\[[@frisoft](https://github.com/frisoft)] - \[Blair Noctis]\[[@nc7s](https://github.com/nc7s)] - \[Danilo Bargen]\[[@dbrgn](https://github.com/dbrgn)] - \[Felix Yan]\[[@felixonmars](https://github.com/felixonmars)] - \[Iliia Maleki]\[[@iliya-malecki](https://github.com/iliya-malecki)] - \[JJ Style]\[[@jj-style](https://github.com/jj-style)] - \[K.B.Dharun Krishna]\[[@kbdharun](https://github.com/kbdharun)] - \[Linus Walker]\[[@Walker-00](https://github.com/Walker-00)] - \[Mohit Raj]\[[@agrmohit](https://github.com/agrmohit)] - \[Nicolai Fröhlich]\[[@nifr](https://github.com/nifr)] - \[Niklas Mohrin]\[[@niklasmohrin](https://github.com/niklasmohrin)] - \[[@qknogxxb](https://github.com/qknogxxb)]\[[@qknogxxb](https://github.com/qknogxxb)] - \[[@tveness](https://github.com/tveness)]\[[@tveness](https://github.com/tveness)] - \[Y.D.X.]\[[@YDX-2147483647](https://github.com/YDX-2147483647)] - \[Zacchary Dempsey-Plante]\[[@zedseven](https://github.com/zedseven)] Thanks! </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

kbdharun added 4 commits May 10, 2023 18:07

Update ci.yml

5520792

ci.yml: fix fmt

227da87

Update gh-pages.yml

b5cf0ec

Update release.yml

d7ab56b

Add support for multiple rust version

b6da21a

kbdharun added 2 commits May 30, 2023 23:19

CI: Update to dtolnay/rust-toolchain, fix checkout (#2)

07e44e6

* CI: Update to dtolnay/rust-toolchain, fix checkout * CI: update toolchain version to 1.62.1 * CI: update toolchain as matrix job

CI: specify components in toolchain

378825d

niklasmohrin requested changes Jul 5, 2023

View reviewed changes

kbdharun commented Jul 6, 2023

View reviewed changes

CI: update actions

4e38d4d

kbdharun requested a review from niklasmohrin July 6, 2023 04:59

kbdharun commented Jul 6, 2023

View reviewed changes

.github/workflows/release.yml Outdated Show resolved Hide resolved

.github/workflows/release.yml Show resolved Hide resolved

kbdharun added 4 commits July 6, 2023 10:33

CI: fix build

caa5c23

CI: release.yml fix indentation and build

8de0ec5

CI: fix build

a6d5756

Merge branch 'dbrgn:main' into main

342d331

dbrgn merged commit 7bd5ac5 into tealdeer-rs:main Jul 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update CI workflows #324

Update CI workflows #324

kbdharun commented May 10, 2023 •

edited

Loading

niklasmohrin commented May 11, 2023

kbdharun commented May 12, 2023

niklasmohrin commented May 29, 2023

kbdharun commented May 30, 2023 •

edited

Loading

niklasmohrin left a comment

niklasmohrin Jul 5, 2023

kbdharun Jul 6, 2023

kbdharun left a comment

kbdharun Jul 6, 2023

kbdharun commented Jul 6, 2023

dbrgn commented Jul 6, 2023

Update CI workflows #324

Update CI workflows #324

Conversation

kbdharun commented May 10, 2023 • edited Loading

Changes

niklasmohrin commented May 11, 2023

kbdharun commented May 12, 2023

niklasmohrin commented May 29, 2023

kbdharun commented May 30, 2023 • edited Loading

niklasmohrin left a comment

Choose a reason for hiding this comment

niklasmohrin Jul 5, 2023

Choose a reason for hiding this comment

kbdharun Jul 6, 2023

Choose a reason for hiding this comment

kbdharun left a comment

Choose a reason for hiding this comment

kbdharun Jul 6, 2023

Choose a reason for hiding this comment

kbdharun commented Jul 6, 2023

dbrgn commented Jul 6, 2023

kbdharun commented May 10, 2023 •

edited

Loading

kbdharun commented May 30, 2023 •

edited

Loading