cargo upgrade --all #35
Conversation
Cargo.toml
Outdated
|
|
||
| [dependencies.env_logger] | ||
| optional = true | ||
| version = "0.4.3" |
There was a problem hiding this comment.
Did you use some kind of auto-formatting tool on this file? Can you change this back to the inline-style? I prefer that :)
There was a problem hiding this comment.
Ah yes, cargo upgrade does not preserve formatting and always outputs in this format as far as I know. I can massage this file into inline shape later today.
| } | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Nice, makes things simpler :)
src/types.rs
Outdated
| //fn test_os_type_decoding_uppercase() { | ||
| // assert_eq!(from_str::<OsType>("\"Linux\"").unwrap(), Linux); | ||
| // assert_eq!(from_str::<OsType>("\"LINUX\"").unwrap(), Linux); | ||
| //} |
There was a problem hiding this comment.
I think we're looking for this, right? serde-rs/serde#586
I'm not sure how important it is to have case insensitive matching, but the workaround by dtolnay seems quite low-effort to implement, what do you think?
There was a problem hiding this comment.
Looks simple enough, but would also be nice to avoid the extra code if it's not needed. I can add the workaround if you would like to keep the support for case-insensitive input?
|
I tried to implement the serde workaround for enums and failed, but found out docopt already provides case insensitive deserialization of enums :) |
|
Sorry, I forgot about this PR...
Very nice :) Thanks for the changes! |
Good suggestion, will integrate that before merging this PR. |
Resolved build errors by moving from rustc-serialize to serde.
dbrgn
force-pushed
the
cargo_upgrade_all
branch
from
f87fc22 to
1dcc781
Compare
Upgraded all dependencies using
cargo upgrade --all(https://crates.io/crates/cargo-edit) and fixed the resulting build errors by moving to serde for deserialization.cargo testfails both on master and this branch so I did not bother with that in this PR (the special command line test invoker does not find the executable (on macOS, latest rust stable, maybe use this: https://github.com/killercup/assert_cli ?)).