Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hack to fix #63 and #91. #111

Merged
merged 1 commit into from
May 11, 2015
Merged

Hack to fix #63 and #91. #111

merged 1 commit into from
May 11, 2015

Conversation

ShawnMilo
Copy link
Collaborator

Uses a string replacement to bypass current limitation on
encoding/xml.

Proposed for @tealeg to approve or veto.

@tealeg
Copy link
Owner

tealeg commented May 11, 2015

@ShawnMilo I'm OK with this as a temporary fix. The tests need to pass mind.

Uses a string replacement to bypass current limitation on
encoding/xml.
@ShawnMilo
Copy link
Collaborator Author

Oops. I ran the tests, but evidently not after the latest change. Tests now pass, re-pushed. Once Travis says it's okay then I'll merge.

ShawnMilo added a commit that referenced this pull request May 11, 2015
@ShawnMilo ShawnMilo merged commit 6b397ee into master May 11, 2015
@ShawnMilo ShawnMilo deleted the numbers_hack branch May 11, 2015 18:07
tealeg pushed a commit that referenced this pull request Apr 1, 2016
tealeg pushed a commit that referenced this pull request Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants