Autowidth #618
Merged
Autowidth #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for that @egpotter - happy to include it. Sorry for the delay in reviewing this, I've been working on a major branch and haven't had much time for tending to these things. |
|
Thanks a lot for merging it! |
dolmen
pushed a commit
to dolmen-go/tealeg-xlsx.fork
that referenced
this pull request
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to implement an autowidth (or autofit) function. There are some issues related to this:
#189
#153
This is not a perfect solution, but I think some people would benefit from it. I separated the proportion function so it can be changed when needed by others. Please let me know in case it does not make sense to merge it, as I need it anyway.