Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): allow reinstallation of broken package #1881

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mitosagi
Copy link
Collaborator

Description

おすすめインストールボタンを押したとき、パッケージのファイルが不足している場合でも再インストールが行われない問題を修正します。また、ファイルが不足している場合のメッセージをapmの内部動作と矛盾のない表現に変更します。

team-apm/apm-data#638 (comment) 参照
InputPipePluginのパッケージデータに"lwinput64.aui"を追加した場合、apmの"AviUtl"タブに「未インストール(ファイルの存在が確認できませんでした。)」と表示されてしまう問題があります。
このPRでメッセージが分かりやすくなり、対処も容易になります。

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mitosagi mitosagi added the Problem: bug Something isn't working label Sep 28, 2024
@mitosagi mitosagi requested a review from a team September 28, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Problem: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants