Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warning: useless cast to type ‘size_t’ {aka ‘unsigned int’} [-Wuseless-cast] #161

Closed
malaterre opened this issue Jan 26, 2022 · 3 comments
Closed

warning: useless cast to type ‘size_t’ {aka ‘unsigned int’} [-Wuseless-cast] #161

malaterre opened this issue Jan 26, 2022 · 3 comments
Milestone
2.3.2

Comments

@malaterre
Copy link
Contributor

malaterre commented Jan 26, 2022 •
edited
Loading

Posting as issues for now:

/<<PKGBUILDDIR>>/src/lookup_table.h: In member function ‘void charls::golomb_code_table::add_entry(uint8_t, charls::golomb_code)’:
/<<PKGBUILDDIR>>/src/lookup_table.h:48:30: warning: useless cast to type ‘size_t’ {aka ‘unsigned int’} [-Wuseless-cast]
   48 |         for (size_t i{}; i < static_cast<size_t>(1U) << (byte_bit_count - length); ++i)
      |

and

/<<PKGBUILDDIR>>/fuzztest/main.cpp: In function ‘int main(int, const char* const*)’:
/<<PKGBUILDDIR>>/fuzztest/main.cpp:75:68: warning: useless cast to type ‘unsigned int’ [-Wuseless-cast]
   75 |                 const ssize_t result{write(1, encoded_data.data(), static_cast<unsigned int>(encoded_data.size()))};
      |                                                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/<<PKGBUILDDIR>>/fuzztest/main.cpp:99:62: warning: useless cast to type ‘unsigned int’ [-Wuseless-cast]
   99 |         const size_t input_length = _read(fd, source.data(), static_cast<unsigned int>(source.size()));
      |                                                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[ 68%] Linking CXX executable fuzztest
@malaterre
Copy link
Contributor Author

oh neat trick:

@vbaderks vbaderks added this to the 2.3.2 milestone Jan 26, 2022
@vbaderks
Copy link
Contributor

Using conditional_static_cast is indeed a very clean way to solve it.

@vbaderks
Copy link
Contributor

This has been resolved with c15be90

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Nov 14, 2022
Update graphics/charls to version 2.3.4
33ab676 
Changes from CHANGELOG.md:

# Change Log
## [2.3.4] - 2021-2-12

### Changed

- Replaced legacy test images.

## [2.3.3] - 2021-2-5

### Fixed

- Fixed [#167](team-charls/charls#167),
  Decoding\Encoding fails on IBM s390x CPU (Big Endian architecture).

## [2.3.2] - 2021-1-29

### Fixed

- Fixed team-charls/charls#160,
  warning: cast from 'unsigned char*' to 'uint16_t*'
  increases required alignment of target type.
- Fixed team-charls/charls#161 ,
  warning: useless cast to type 'size_t' {aka 'unsigned int'}
  [-Wuseless-cast].

### Changed

- Updates to the CMakeLists.txt for Unix builds (except macOS)
  to hide more symbols from the shared library.
- C++14 is now the minimum version instead of explicitly required.
  This allows consuming applications more flexibility.
  Typically CMake will select the latest C++ standard version that
  the used C++ compiler supports.

## [2.3.1] - 2021-1-25

### Fixed

- Fixed team-charls/charls#155 ,
  charls::jpegls_decoder::decode: 2 overloads have similar conversions
  in v2.3.0

## [2.3.0] - 2022-1-24

### Added

- The encoder API has been extended with a rewind method that can be
  used to re-use a configured encoder to encode multiple images in a loop.
- Added support to decode JPEG-LS images that use restart markers
  team-charls/charls#92 .
- Added support to write and read comment (COM) segments
  team-charls/charls#113 .
- Added support to encode/decode oversized images
  (width or height larger then 65535).
- Extended the validation of the encoded JPEG-LS byte stream during decoding.
- Added support to encode JPEG-LS images with:
  - The option to ensure the output stream has an even size.
  - The option to write the CharLS version number as a comment (COM segment)
    to the output stream.
  - The option to write the coding parameters to the output stream if
    the bits per pixel are larger then 12 (enabled by default).
- Usage of compiler specific attributes on the public API as replacement for
  ``[[nodiscard]]`` (which is a C++17 feature).

### Fixed

- Fixed team-charls/charls#84 ,
  Default preset coding parameters not computed for unset values.
- Fixed team-charls/charls#102 ,
  CMake find_package(charls 2.2.0 REQUIRED) not working.

### Changed

- CMakeSettings.json has been replaced with CMakePresets.json.
- Non default coding parameters are explicitly stored in
  the output stream during encoding.
- GCC shared library release builds are now using LTO
  (Link Time Optimization).
- Some functions use compiler intrinsics for slightly better performance.

## [2.2.1] - 2022-2-3

### Fixed

- Backport of fix for team-charls/charls#167 ,
  Decoding\Encoding fails on IBM s390x CPU (Big Endian architecture).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.2
Development

No branches or pull requests
2 participants
@malaterre @vbaderks