Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#619] 피드 커뮤니티 페이징 버그 수정 #620

Merged
merged 4 commits into from
Dec 9, 2021

Conversation

yunyezl
Copy link
Member

@yunyezl yunyezl commented Dec 6, 2021

  • iOS 14.3 에서 터지는 버그 수정
  • 페이징 할 때 데이터 섞이는 문제 방지

Resolve #619

@yunyezl yunyezl added fix 🚨 버그 수정 (bug fix) yezi✨ 예지 도약중 ㅋㅋ labels Dec 6, 2021
@yunyezl yunyezl self-assigned this Dec 6, 2021
@@ -140,8 +141,11 @@ class FeedViewController: UIViewController {
if currentPage == 0 {
allFeeds = feed
} else {
allFeeds.feeds.append(contentsOf: feed.feeds)
if cachedPages.filter({ $0 == currentPage }).count == 0 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오.. 함수 잘쓴다 엉니야

Copy link
Contributor

@jeongchoyi jeongchoyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

왜 터졌던건가요 ?!

@yunyezl
Copy link
Member Author

yunyezl commented Dec 9, 2021

왜 터졌던건가요 ?!

현재 페이지 계산하는 거 때문에 getIndexPath 함수로 셀 내부에서 현재가 몇번 째 셀인지 구해줬는데 그 부분에서 터져서 바깥에서 cell indexPath 넣어주는 방식으로 변경했슴당 ~!

@yunyezl yunyezl merged commit e32da8a into team-mohaeng:develop Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix 🚨 버그 수정 (bug fix) yezi✨ 예지 도약중 ㅋㅋ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[fix] 피드 OS 14.3 에서 터지는 버그
3 participants