Fix bug related to the teardown method and old RNCryptor version #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 1, 2017 09:57
Previously if someone added custom keys or overwrote a value the new configuration file overwrote every existing key the original configuration file had. This caused problems because when the original configuration value was modified with a new application version you still get the old config value from code. Now the new config file only saves the changes.
If you overwrote an existing key which was in the original configuration file and then set it to nil you get nil value when you wanted to tead the key for the first time but after application relaunch you got the original configuration value. Now you will get the original configuration value for the first time too.
… the SCConfiguration itself
reden87
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #7 and #8