Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no support for filters in listener #49

Closed
solidhtp opened this issue Oct 5, 2021 · 3 comments · Fixed by #53
Closed

no support for filters in listener #49

solidhtp opened this issue Oct 5, 2021 · 3 comments · Fixed by #53

Comments

@solidhtp
Copy link

solidhtp commented Oct 5, 2021

Hello,

ActiveMQ supports filters by JMS selector expressions or XPath. rhea supports message filtering as described here.
@Listen accepts only string type in source.

@Listen(source: string, options: ListenOptions)

In order to support filters source should be type of string | Source Source as described in this line. I tried it locally with type Source and filters were working fine.

I can create a PR which simply changes the source type from string to string | Source.
@raschan
Copy link
Collaborator

raschan commented Oct 6, 2021

Hi @solidhtp ,

Awesome, a PR would be welcomed.

solidhtp added a commit to solidhtp/nest-amqp that referenced this issue Oct 6, 2021
@solidhtp
Changed source type in Listen decorator to Source to support filters.
8372209 
Fixes team-supercharge#49.
@solidhtp solidhtp mentioned this issue Oct 6, 2021
Closed
@solidhtp
Copy link
Author

solidhtp commented Oct 6, 2021

@raschan PR created. Please merge.

raschan added a commit that referenced this issue Mar 29, 2022
@raschan
feat(listen): add Source as an input type
75be4fe 
Fixes #49
raschan added a commit that referenced this issue Mar 29, 2022
@raschan
feat(listen): add support for Source in listener
f9c563b 
Fixes #49
@raschan raschan mentioned this issue Mar 29, 2022
Merged
raschan added a commit that referenced this issue Mar 29, 2022
@raschan
feat(listen): add support for Source in listener
2cb6ee8 
Fixes #49
@raschan
Copy link
Collaborator

raschan commented Mar 29, 2022

Hi @solidhtp

Sorry for the delay, life happened....

I've updated the package with support for the Source object defined in rhea-promise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@raschan @solidhtp