Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Telnyx ID getter #131

Merged
merged 1 commit into from
Jan 9, 2021
Merged

Add Telnyx ID getter #131

merged 1 commit into from
Jan 9, 2021

Conversation

SuaYoo
Copy link
Contributor

@SuaYoo SuaYoo commented Jan 9, 2021 •
edited
Loading

Add getter for Telnyx IDs. This makes for better documentation of Telnyx IDs as well.

📝 To Do

  • All linters pass
  • All tests pass
  • Change documentation based on my changes

✋ Manual testing

  1. Run react-audio example.
  2. Make a call. Verify that call.telnyxIDs is an object with empty values (unless making a Call Control call)

🦊 Browser testing

Desktop

  • Edge (latest)
  • Chrome
  • Firefox
  • Safari

@SuaYoo SuaYoo merged commit 0cc6a41 into main Jan 9, 2021
@SuaYoo SuaYoo deleted the WEBRTC-303_Show_telnyx_id_options branch January 9, 2021 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeividVeloso DeividVeloso Awaiting requested review from DeividVeloso

@guillermobattistel guillermobattistel Awaiting requested review from guillermobattistel

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SuaYoo