Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(WEBRTC-107): added support to chose servers dynamically #19

Merged
merged 3 commits into from
Jun 5, 2020
Merged

feat(WEBRTC-107): added support to chose servers dynamically #19

merged 3 commits into from
Jun 5, 2020

Conversation

DeividVeloso
Copy link
Contributor

@DeividVeloso DeividVeloso commented Jun 4, 2020 •
edited
Loading

Added support to chose servers dynamically.

  • You can choose between servers development or production with property env
  • You can pass your own iceServers with property iceServers
  • Updated examples to support env, host and iceServers

📝 To Do

  • All linters pass
  • All tests pass
  • Change documentation based on my changes

✋ Manual testing

  1. npm run build in root folder
  2. Navigate into examples/vanilla
  3. Open index.html
  4. Click in connect and see in Network tab on WS option if is connected in host rtc (production host)
  5. Uncheck production checkbox and click in connect and see in Network tab on WS option if is connected in host rtcdev (production host)

🦊 Browser testing

Desktop

  • Edge (latest)
  • Chrome
  • Firefox
  • Safari

📸 Screenshots

Description Screenshot
Desktop image

@DeividVeloso DeividVeloso marked this pull request as ready for review June 5, 2020 13:21
@DeividVeloso DeividVeloso merged commit 9ce03e0 into master Jun 5, 2020
@DeividVeloso DeividVeloso deleted the WEBRTC-107 branch June 5, 2020 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-telnyx jonathan-telnyx jonathan-telnyx approved these changes

@hugooliveirad hugooliveirad Awaiting requested review from hugooliveirad

@SuaYoo SuaYoo Awaiting requested review from SuaYoo

@dganoff dganoff Awaiting requested review from dganoff

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DeividVeloso @jonathan-telnyx