Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(WEBRTC-121): Added and configured ESlint and Husky #27

Merged
merged 1 commit into from
Jul 14, 2020

Conversation

DeividVeloso
Copy link
Contributor

  • Added and configured ESlint and Husky

πŸ“ To Do

  • All linters pass
  • All tests pass
  • Change documentation based on my changes

βœ‹ Manual testing

  1. run npm run build
  2. check if the build was generated successfully

🦊 Browser testing

Desktop

  • Edge (latest)
  • Chrome
  • Firefox
  • Safari

@DeividVeloso DeividVeloso changed the title feat(WEBRTC-121): added and configured ESlint and Husky feat(WEBRTC-121): Added and configured ESlint and Husky Jul 14, 2020
Copy link
Contributor

@hugooliveirad hugooliveirad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment

node_modules
lib
coverage
./*.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you ignoring root .js files?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To ignore configs files such as

jest.config.js
rollup.config.js

@DeividVeloso DeividVeloso merged commit a44d97b into master Jul 14, 2020
@DeividVeloso DeividVeloso deleted the WEBRTC-121 branch July 14, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants