Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(WEBRTC-125): Updated storybook react example #29

Merged
merged 8 commits into from
Jul 23, 2020
Merged

fix(WEBRTC-125): Updated storybook react example #29

merged 8 commits into from
Jul 23, 2020

Conversation

DeividVeloso
Copy link
Contributor

@DeividVeloso DeividVeloso commented Jul 23, 2020 •
edited
Loading

  • Updated storybook react example.
  • Changed unmute/mute function to use toggleAudioMute.
  • Updated dependencies to avoid problems with vulnerabilities.
  • Updated docs to listing the new methods available.
  • Added PropTypes in the components

📝 To Do

  • All linters pass
  • All tests pass
  • Change documentation based on my changes

✋ Manual testing

  1. navigate into examples/react
  2. run npm install && npm start
  3. access http://localhost:6006/?path=/story/webdialer--example
  4. make a call

🦊 Browser testing

Desktop

  • Edge (latest)
  • Chrome
  • Firefox
  • Safari

@DeividVeloso DeividVeloso marked this pull request as ready for review July 23, 2020 20:14
@DeividVeloso DeividVeloso merged commit 0a8c110 into master Jul 23, 2020
@DeividVeloso DeividVeloso deleted the WEBRTC-125 branch July 23, 2020 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugooliveirad hugooliveirad hugooliveirad approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DeividVeloso @hugooliveirad