Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(WEBRTC-134) - Authentication required #33

Merged
merged 1 commit into from
Aug 4, 2020
Merged

fix(WEBRTC-134) - Authentication required #33

merged 1 commit into from
Aug 4, 2020

Conversation

DeividVeloso
Copy link
Contributor

  • Removed unnecessary code that ran without user and password.

📝 To Do

  • All linters pass
  • All tests pass
  • Change documentation based on my changes

✋ Manual testing

  1. npm i && npm run build
  2. Navigate into examples/react
  3. Provide your user and password wrongly and try to make a call
  4. See in the console log the message error Authentication Failed
  5. Refresh the page and provide your user and password rightly and try to make a call
  6. Check in the console log that you don't have the error about Authentication required

🦊 Browser testing

Desktop

  • Edge (latest)
  • Chrome
  • Firefox
  • Safari

@DeividVeloso DeividVeloso merged commit 34327dd into master Aug 4, 2020
@DeividVeloso DeividVeloso deleted the WEBRTC-134 branch August 4, 2020 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugooliveirad hugooliveirad hugooliveirad approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DeividVeloso @hugooliveirad