fix(ENGDESK-23349): bind telnyxids on ringing event for outbound calls #342
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
I added code to assign telnyx ids when the ringing event is received.
Those ids are initially undefined because they are generated by the telephony engine, the
ringing
event is the first event that has these ids.Help needed
I couldn't check if
telnyxCallControlId
is set correctly, I'm new here, not sure how to test that manually📝 To Do
✋ Manual testing
🦊 Browser testing
Desktop
📸 Screenshots
| usage.gif | |