Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: propagate session id with error event #358

Merged
merged 2 commits into from
May 28, 2024
Merged

feat: propagate session id with error event #358

merged 2 commits into from
May 28, 2024

Conversation

farhat-ha
Copy link
Collaborator

@farhat-ha farhat-ha commented May 28, 2024 •
edited
Loading

XXXX-YYY

  1. Propagate session id along side error for telnyx.error and telnyx.socket.error
  2. Include SDK version in UserAgent (WEBRTC-2218)
  3. Disable storing session id in session storage to avoid multiple connections with the same session id (WEBRTC-2217)

📝 To Do

  • All linters pass
  • All tests pass
  • Change documentation based on my changes

✋ Manual testing

  1. Provide manual testing instructions

🦊 Browser testing

Desktop

  • Edge (latest)
  • Chrome
  • Firefox
  • Safari

📸 Screenshots

Description Screenshot
Desktop
usage.gif

@farhat-ha farhat-ha self-assigned this May 28, 2024
@farhat-ha farhat-ha requested a review from DeividVeloso May 28, 2024 10:51
jonathan-telnyx
jonathan-telnyx approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@jonathan-telnyx jonathan-telnyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@farhat-ha farhat-ha merged commit 0f931ed into main May 28, 2024
2 checks passed
@farhat-ha farhat-ha deleted the WEBRTC-2217_WEBRTC-2218 branch May 28, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeividVeloso DeividVeloso DeividVeloso approved these changes

@jonathan-telnyx jonathan-telnyx jonathan-telnyx approved these changes

@ericaprieto ericaprieto Awaiting requested review from ericaprieto ericaprieto is a code owner automatically assigned from team-telnyx/frontend

@lmao12 lmao12 Awaiting requested review from lmao12 lmao12 is a code owner automatically assigned from team-telnyx/frontend

@priscillasantana priscillasantana Awaiting requested review from priscillasantana priscillasantana is a code owner automatically assigned from team-telnyx/frontend

Assignees

@farhat-ha farhat-ha

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@farhat-ha @DeividVeloso @jonathan-telnyx