Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: attach reconnection token to host #367

Merged
merged 1 commit into from
Aug 14, 2024
Merged

feat: attach reconnection token to host #367

merged 1 commit into from
Aug 14, 2024

Conversation

farhat-ha
Copy link
Collaborator

@farhat-ha farhat-ha commented Aug 14, 2024

WEBRTC-2246

📝 To Do

voice-sdk-proxy now returns a token used to re-establish ws connection to the b2bua-rtc instance in case the ws disconnects.

this change saves the token to session storage and attaches it (if it exists) to the websocket host.

  • All linters pass
  • All tests pass
  • Change documentation based on my changes

✋ Manual testing

  1. Provide manual testing instructions

🦊 Browser testing

Desktop

  • Edge (latest)
  • Chrome
  • Firefox
  • Safari

📸 Screenshots

Description Screenshot
Desktop
usage.gif

Copy link
Contributor

@DeividVeloso DeividVeloso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@farhat-ha farhat-ha merged commit 27be846 into main Aug 14, 2024
2 checks passed
@farhat-ha farhat-ha deleted the WEBRTC-2246 branch August 14, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants