Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(WEBRTC-187): investigate and fix bundle size #47

Merged
merged 2 commits into from
Oct 26, 2020
Merged

feat(WEBRTC-187): investigate and fix bundle size #47

merged 2 commits into from
Oct 26, 2020

Conversation

DeividVeloso
Copy link
Contributor

@DeividVeloso DeividVeloso commented Oct 26, 2020 •
edited
Loading

  • Reduce bundle size of the projects SDK's by 33%.
  • Update examples to use the last version of SDK's.

📝 To Do

  • All linters pass
  • All tests pass
  • Change documentation based on my changes

✋ Manual testing

  1. Navigate o packages/js/examples/react-audio
  2. Run npm i && npm setup
  3. Make a call and see if it is working.

🦊 Browser testing

Desktop

  • Edge (latest)
  • Chrome
  • Firefox
  • Safari
  • React Native Android

@DeividVeloso DeividVeloso merged commit 1bb3371 into master Oct 26, 2020
@DeividVeloso DeividVeloso deleted the WEBRTC-187 branch October 26, 2020 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugooliveirad hugooliveirad hugooliveirad approved these changes

@SuaYoo SuaYoo Awaiting requested review from SuaYoo

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DeividVeloso @hugooliveirad