🔀 :: (#207) 상벌점 부여 알림 content 수정 #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyk1029
requested review from
jhhong0509,
lyutvs,
eogus2513,
oliver37632,
jaemin05,
leeseojune53 and
jeongho1209
as code owners
jaemin05
reviewed
Jul 19, 2023
point-domain/src/main/kotlin/com/xquare/v1servicepoint/point/api/impl/PointHistoryApiImpl.kt
Outdated
Show resolved
Hide resolved
|
이렇게 바꾸신 이유가 있을까요? |
상벌점 사유가 어떻게 되든 '으로' 로 되어 있었는데 전에 사유에 따라 유연하게 바뀌게끔 요구사항이 들어와서 바꾸었습니다 |
jaemin05
reviewed
Jul 19, 2023
point-domain/src/main/kotlin/com/xquare/v1servicepoint/point/api/impl/PointHistoryApiImpl.kt
Outdated
Show resolved
Hide resolved
jaemin05
approved these changes
Jul 19, 2023
leeseojune53
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. 마지막 글자의 받침 유니코드 - 처음 시작하는 유니코드(0번째, 사진 참고) 2. 종성의 개수만큼 나머지 연산 3. 사진 참고하여 비교문 작성