🔀 :: (#220) 게시글, 댓글 soft delete 추가 #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyk1029
requested review from
jhhong0509,
lyutvs,
eogus2513,
oliver37632,
jaemin05,
leeseojune53 and
jeongho1209
as code owners
lyutvs
approved these changes
Aug 18, 2023
| @@ -23,4 +23,6 @@ public class Comment { | |||
| private final LocalDateTime createAt; | |||
|
|
|||
| private final LocalDateTime updatedAt; | |||
|
|
|||
| private final Boolean isDeleted = false; | |||
| @@ -36,9 +36,16 @@ public class CommentEntity extends BaseUUIDEntity { | |||
| @Column(nullable = false) | |||
| private LocalDateTime updatedAt; | |||
|
|
|||
| @Column(columnDefinition = "BIT(1) default 0", nullable = false) | |||
| @@ -36,9 +36,16 @@ public class CommentEntity extends BaseUUIDEntity { | |||
| @Column(nullable = false) | |||
| private LocalDateTime updatedAt; | |||
|
|
|||
| @Column(columnDefinition = "BIT(1) default 0", nullable = false) | |||
| private Boolean isDeleted; | |||
There was a problem hiding this comment.
p3) nullable은 false인데 Primitive type으로 설정하는게 좋을 것 같습니다.
| @@ -42,11 +42,18 @@ public class FeedEntity extends BaseUUIDEntity { | |||
| @Column(nullable = false) | |||
| private String authorityType; | |||
There was a problem hiding this comment.
Q) Enum Type으로 하지 않은 이유가 있나요?
| @@ -42,11 +42,18 @@ public class FeedEntity extends BaseUUIDEntity { | |||
| @Column(nullable = false) | |||
| private String authorityType; | |||
|
|
|||
| @Column(columnDefinition = "BIT(1) default 0", nullable = false) | |||
| private Boolean isDeleted; | |||
There was a problem hiding this comment.
Q) nullable false 인데 primitive 사용하지 않은 이유가 있나요?
| @@ -39,7 +39,8 @@ public void saveComment(Comment comment) { | |||
|
|
|||
| @Override | |||
| public void deleteCommentById(UUID commentId) { | |||
| commentRepository.deleteById(commentId); | |||
| CommentEntity comment = getCommentById(commentId); | |||
| comment.updatedIsDeleted(true); | |||
There was a problem hiding this comment.
P4) comment.delete()가 더 명확한 것 같습니다!
| feedMapper.domainToEntity(feed) | ||
| ); | ||
| FeedEntity feedEntity = getFeedEntityById(feed.getId()); | ||
| feedEntity.updateIsDeleted(true); |
There was a problem hiding this comment.
p1) 여기서 manual하게 save해서 update를 해주는게 좋을 것 같습니다
| @@ -81,7 +80,7 @@ public FeedPageList queryAllFeedByCategory(UUID categoryId, LocalDateTime time, | |||
| .on(feedEntity.id.eq(feedLikeEntity.feedEntity.id)) | |||
| .leftJoin(commentEntity) | |||
| .on(feedEntity.id.eq(commentEntity.feedEntity.id)) | |||
| .where(expression.and(categoryIdEq(categoryId))) | |||
| .where(expression.and(categoryIdEq(categoryId)), feedEntity.isDeleted.eq(false)) | |||
There was a problem hiding this comment.
Q) isDeleted가 true이면 soft-delete된 값일텐데, 이건 따로 BooleanExpression으로 빼서 관리하는게 어떤가요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.