Skip to content

Feat [#355] 프로필 변경 확인 팝업 및 수정 사항 적용 #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 3, 2024

Conversation

Zoe0929
Copy link
Member

@Zoe0929 Zoe0929 commented Mar 3, 2024

⛏ 작업 내용

  • 프로필 변경 시 확인하는 팝업을 추가했습니다.
  • 논의된 변경 사항을 적용했습니댜.

📌 PR Point!

  • 온보딩 아이디 중복 확인에서 빈 문자를 보냈을 때 true 값이 들어옵니다. 이로 인해 "이미 존재하는 아이디입니다." 라이팅이 적용된 것을 확인했습니다. 수정을 위해 초기 상태로 만드는 함수 setInitialState()를 만들어서 중복성 검사 전 빈 문자열인 경우 초기 상태를 유지하도록 구현했습니다.
private func setInitialStyle() {
        baseView.idTextField.helperLabel.setLabelStyle(text: StringLiterals.Onboarding.Id.idHelper, State: .id)
        baseView.idTextField.textField.setButtonState(state: .id)
        nextButton.setButtonEnable(state: false)
    }

func textFieldDidEndEditing(_ textField: UITextField) {
        if textField == baseView.idTextField.textField {
            guard let idText = textField.text else { return }
            if idText.isEmpty {
                setInitialStyle()
                return
            }
            self.checkDuplicate(id: idText)
        }
        self.checkButtonEnable()
    }

📸 스크린샷

구현 내용 스크린샷
프로필 변경 팝업
아이디 빈 칸일 때 라이팅 적용 RPReplay_Final1709467818
상점 라이팅 변경 적용

✅ Issue

Resolved #355

@Zoe0929 Zoe0929 added feat🪄 기능 구현 지희🐰 labels Mar 3, 2024
@Zoe0929 Zoe0929 requested review from Heyjooo and chaentopia March 3, 2024 13:58
@Zoe0929 Zoe0929 self-assigned this Mar 3, 2024
@Zoe0929 Zoe0929 linked an issue Mar 3, 2024 that may be closed by this pull request
1 task
Copy link
Collaborator

@chaentopia chaentopia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P5
고생하셨습니다! 새 뷰까지 뚝딱.. 👍🏻💭

}

// MARK: Objc Function
@objc func noButtonClicked() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

사소한 의견이지만 noButtonTapped()로 바꾸는 건 어떨까용!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dce151f 반영했습니다! 감사합니다🥰

Copy link
Contributor

@Heyjooo Heyjooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P5
수고하셨숩니다 !!!!

Comment on lines +31 to +36
private let editSchoolInfoView = EditSchoolInfoView()
private let studentIdViewController = StudentIdViewController()
private let schoolSearchViewController = FindSchoolViewController()
private let majorSearchViewController = FindMajorViewController()
private lazy var studentIdView = StudentIdView()
private let editCheckView = EditCheckView()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P5
private 키워드 추가 좋으네요 !

@Zoe0929 Zoe0929 merged commit e05924b into develop Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Feat] 프로필 변경 확인 팝업 추가 및 수정사항 적용
3 participants