-
Notifications
You must be signed in to change notification settings - Fork 2
Feat [#355] 프로필 변경 확인 팝업 및 수정 사항 적용 #357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P5
고생하셨습니다! 새 뷰까지 뚝딱.. 👍🏻💭
} | ||
|
||
// MARK: Objc Function | ||
@objc func noButtonClicked() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
사소한 의견이지만 noButtonTapped()로 바꾸는 건 어떨까용!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dce151f 반영했습니다! 감사합니다🥰
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P5
수고하셨숩니다 !!!!
private let editSchoolInfoView = EditSchoolInfoView() | ||
private let studentIdViewController = StudentIdViewController() | ||
private let schoolSearchViewController = FindSchoolViewController() | ||
private let majorSearchViewController = FindMajorViewController() | ||
private lazy var studentIdView = StudentIdView() | ||
private let editCheckView = EditCheckView() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P5
private 키워드 추가 좋으네요 !
⛏ 작업 내용
📌 PR Point!
setInitialState()
를 만들어서 중복성 검사 전 빈 문자열인 경우 초기 상태를 유지하도록 구현했습니다.📸 스크린샷
✅ Issue
Resolved #355