Feat [#373] 탈퇴 - '앱에 아는 친구가 없어서' 변경사항 반영 #374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zoe0929
requested changes
Jun 7, 2024
Comment on lines
63
to
68
| withdrawalNoFriendView.nextButtonAction = { | ||
| self.showAlert() | ||
| } | ||
| withdrawalNoFriendView.wowButtonAction = { | ||
| NotificationCenter.default.post(name: Notification.Name("moveToRecommend"), object: nil) | ||
| } |
There was a problem hiding this comment.
p3. 요 부분에 앰플리튜드 넣어야 할 것 같은데 추후 작업 예정인건지 궁금합니다!
There was a problem hiding this comment.
맞다.. 앰플리튜드 까먹었네요
얼른 할게요
Heyjooo
approved these changes
Jun 10, 2024
Comment on lines
+106
to
+121
| extension WithdrawalNoFriendView { | ||
| @objc private func closeView() { | ||
| self.isHidden = true | ||
| self.removeFromSuperview() | ||
| } | ||
|
|
||
| @objc private func nextButtonTapped() { | ||
| closeView() | ||
| nextButtonAction() | ||
| } | ||
|
|
||
| @objc private func wowButtonTapped() { | ||
| closeView() | ||
| wowButtonAction() | ||
| } | ||
| } |
There was a problem hiding this comment.
P5
앞으러 이런식으로 깔끔하게 작성해야겠네요 !-!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛏ 작업 내용
YELLO-iOS/YELLO-iOS/YELLO-iOS/Presentation/TabBar/YELLOTabBarController.swift
Lines 390 to 392 in 37c2c50
📌 PR Point!
📸 스크린샷
✅ Issue
Resolved #373