Robot configuration #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bread-n-Butter06
previously approved these changes
Sep 18, 2023
|
Not 100% sure what they are, but the merge conflicts need to be fixed. Be careful to not delete code that we need. The following commands should help: And then go through the process from last week of using git status to view the conflicting files, resolve conflicts in vscode, and use git add . And git rebase --continue when you're done fixing a particular commit |
jkleiber
requested changes
Sep 18, 2023
|
|
||
| public RobotContainer() { | ||
| drive.setDefaultCommand(new TankDrive(drive, | ||
| drive.setDefaultCommand(new TankDrive(drive, |
There was a problem hiding this comment.
The default command should match the drive mode
| @@ -25,9 +18,9 @@ public enum DriveMode { | |||
|
|
|||
| public DriveSubsystem(ChassisMode chassisMode, DriveMode driveMode) { | |||
| if (chassisMode == ChassisMode.B_TEAM) { | |||
| driveHardware = new DriveSparkMAX(DriveConstants.frontLeftID, DriveConstants.frontRightID, DriveConstants.backLeftID, DriveConstants.backRightID); | |||
| driveHardware = new DriveSparkMAX(B_Configs.frontLeftID, B_Configs.frontRightID, B_Configs.backLeftID, B_Configs.backRightID); | |||
There was a problem hiding this comment.
Shouldn't all these configs be passed in via the robot configuration class rather than these constants
There was a problem hiding this comment.
Should the DriveSubsystem constructor have all of the motor controller ids then?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.