replacement basic auto #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkleiber
reviewed
Oct 27, 2023
| @@ -64,5 +67,9 @@ private void configureButtonBindings() { | |||
|
|
|||
| } | |||
|
|
|||
| public Command getAutonomous() { | |||
| return new Auto(arm, drive, SmartDashboard.getNumber("Auto Drive Time", 5)); | |||
There was a problem hiding this comment.
Can we make this not on smartdashboard (just make it a constant)?
There was a problem hiding this comment.
B bot should travel 35 feet in 5 seconds at 50% speed, this probably should be a smaller value btw
There was a problem hiding this comment.
Isn't ChassisSpeeds in m/s? If so then this would be 2.5 meters of movement approximately
There was a problem hiding this comment.
ohhh, ok that's fine just very slow
PChild
reviewed
Oct 27, 2023
| new InstantCommand(() -> arm.setMode(Mode.IDLE)), | ||
| new ParallelRaceGroup( | ||
| new ArmMove(arm, Mode.SHOOT_HIGH).raceWith(new WaitCommand(1.0)), | ||
| new ParallelRaceGroup ( |
There was a problem hiding this comment.
Is ParallelRaceGroup correct here? Will ArmMove complete and end the race?
There was a problem hiding this comment.
ArmMove never is finished, so it shouldn't win the race against the wait
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.