Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

66 geometry math monitors wpilib interface docstrings #89

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Samson560915
Copy link

Javadoc for geometry, math, monitors, wpilib interface.

@Samson560915 Samson560915 self-assigned this Jan 16, 2025
@Samson560915 Samson560915 linked an issue Jan 16, 2025 that may be closed by this pull request
4 tasks
@aidnem
Copy link
Contributor

aidnem commented Jan 17, 2025

@Samson560915 there are some merge conflicts. If you switch to the main branch, pull it, and then swap back to your branch and try git rebase main. Then you just have to resolve the merge conflicts (VSCode can help with this, click "resolve in merge editor"). I would say accept the changes from the main branch and then re-add javadocs, since they've added some stuff to DriveWithJoysticks since you made this branch. Once you've fixed all of the conflicts from one step, type git rebase --continue to continue on to the next commit, where there might be more conflicts. Repeat this until the rebase is done, then run git push --force to force-push your changes (because you rebased, the branch history won't match and you'll be unable to do a normal push).

avidraccoon and others added 4 commits January 17, 2025 12:51
* Implement Naming of Serialized Fields

* Fix typo

* WIP

* Not sure

* I think this fixes the build errors

* Maybe this time it will work
@Samson560915 Samson560915 requested a review from jkleiber January 17, 2025 23:17
@jkleiber
Copy link
Member

@Samson560915 I checked out your branch locally and there are still some missing javadocs - you probably need to rebase again to pull in changes that have recently gone into main.

After doing that, please run gradlew publishToMavenLocal to see which docstrings remain. It looks like nobody is claiming the controls package in the ticket split, so you may just need to do that one in order to get javadoc errors to 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add javadoc docstrings to Geometry, Math, Monitors, and WPILib interface
5 participants