Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amy/add resolver workaround to metro config #13

Closed
wants to merge 3 commits into from
Closed

Amy/add resolver workaround to metro config #13

wants to merge 3 commits into from

Conversation

AmyLeighEddins
Copy link
Collaborator

@AmyLeighEddins AmyLeighEddins commented Mar 15, 2022 •
edited
Loading

Add resolver workaround to metro config

Because:

  • When creating a new project and running it we are getting an error on startup

This commit:

  • Adds resolver as a workaround by configuring Metro to understand the .cjs file extension until this issue is resolved. Solution found in Apollo Client 3.5.4 release notices here.

Amy Eddins added 3 commits March 15, 2022 10:06
Add cjs in resolver in metro config as an Apollo supported workaround…
0765b2a 
… for the issue where the Metro bundler config does not include the cjs extension by default
Add comments
a2f0ba4
Add issue fix explanation to readme
1504f98
@AmyLeighEddins AmyLeighEddins requested a review from makozlo March 15, 2022 18:22
@makozlo makozlo closed this Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makozlo makozlo Awaiting requested review from makozlo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AmyLeighEddins @makozlo