Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show a descriptive error when unit-tests fail to load requirejs package on some node versions #2699

Merged
merged 2 commits into from
Jun 7, 2020

Conversation

davidfirst
Copy link
Member

@davidfirst davidfirst commented May 29, 2020

Before, when running the unit-tests on node versions >= 12.16.0, it'd just exit the process without any error.

The root issue is with "rewire" package. See jhnns/rewire#178 for more details.

@AppVeyorBot
Copy link

Build bit 1.0.10430 failed (commit 2c0f39522e by @davidfirst)

@davidfirst davidfirst merged commit 211248f into harmony/main Jun 7, 2020
@davidfirst davidfirst deleted the harmony/show-error-on-unit-test-failure branch June 7, 2020 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants