refactor, reduce the usage of legacy scope/comp for snapping API #9437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiladShoham
approved these changes
Jan 10, 2025
davidfirst
added a commit
that referenced
this pull request
Jan 17, 2025
In some cases, when tagging or snapping with `--build` flag, the buildStatus remain `pending`, instead of `succeed`. This is a regression caused by #9437. It happens for example when tagging/snapping aspects. It's happening because the `ConsumerComponent instance inside the harmony component is different than the one originally created. Although the harmony component is created by the legacy, but in case the `Workspace` aspect already had this component in the cache, it won't use the provided legacy, but create a new one. As a result, the buildStatus was set to one instance of ConsumerComponent and another instance was saved into the filesystem. This PR fixes it by making sure it's using the same instance of `ConsumerComponent`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the Snapping API by changing from ConsumerComponent to Component and prefer using Scope over LegacyScope when working with Remotes.