Merge pull request #2502 from teamcapybara/drop_support_for_obsolete_…

…selenium

Drop support for Selenium < 3.142.7

History.md

@@ -4,9 +4,11 @@ Release date: unreleased
 ### Changed
 
 * Ruby 2.6.0+ is now required
+* Minimum selenium-webdriver support is now 3.142.7
 
 ### Added
 
+* Support for selenium-webdriver 4.x
 * `allow_label_click` accepts click options to be used when clicking an associated label
 * Deprecated `allow_gumbo=` in favor of `use_html5_parsing=` to enable use of Nokogiri::HTL5 when available
 * `Session#active_element` returns the element with focus - Not supported by the `RackTest` driver [Sean Doyle]

capybara.gemspec

@@ -54,7 +54,7 @@ Gem::Specification.new do |s|
   s.add_development_dependency('rubocop-rspec', ['~>2.0'])
   s.add_development_dependency('sauce_whisk')
   s.add_development_dependency('selenium_statistics')
-  s.add_development_dependency('selenium-webdriver', ['~>3.5'])
+  s.add_development_dependency('selenium-webdriver', ['>=3.142.7', '<5.0'])
   s.add_development_dependency('sinatra', ['>= 1.4.0'])
   s.add_development_dependency('uglifier')
   s.add_development_dependency('webdrivers', ['>=3.6.0']) # if ENV['CI']

gemfiles/Gemfile.base-versions

@@ -7,6 +7,6 @@ gem 'rack', '1.6.0'
 gem 'nokogiri', '~>1.8.0'
 gem 'xpath', '~>3.2.0'
 gem 'rspec', '~>3.5.0'
-gem 'selenium-webdriver', '3.141.0'
+gem 'selenium-webdriver', '3.142.7'
 gem 'irb', '~>1.1.1'
 gem 'webdrivers', '~>4.5.0'

lib/capybara/selenium/driver.rb

@@ -43,7 +43,7 @@ def load_selenium
           Gem::Version.new(Selenium::WebDriver::VERSION)
         end
 
-      unless Gem::Requirement.new('>= 3.5.0').satisfied_by? @selenium_webdriver_version
+      unless Gem::Requirement.new('>= 3.142.7').satisfied_by? @selenium_webdriver_version
         warn "Warning: You're using an unsupported version of selenium-webdriver, please upgrade."
       end