Updating to JQuery 3.x somehow changes the visibility calculation - w…

…as 1.x polyfilling something in Chrome?
teamcapybara · Oct 24, 2021 · 4e03c10 · 4e03c10
1 parent a400a04
commit 4e03c10
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/capybara/spec/session/fill_in_spec.rb b/lib/capybara/spec/session/fill_in_spec.rb
@@ -225,7 +225,7 @@
       @session.fill_in('with_change_event', with: '')
       # click outside the field to trigger the change event
       @session.find(:css, 'h1', text: 'FooBar').click
-      expect(@session).to have_selector(:css, '.change_event_triggered', match: :one)
+      expect(@session).to have_selector(:css, '.change_event_triggered', match: :one, visible: :all)
     end
   end
 

diff --git a/spec/shared_selenium_session.rb b/spec/shared_selenium_session.rb
@@ -79,7 +79,7 @@
         session.fill_in('with_change_event', with: '')
         # click outside the field to trigger the change event
         session.find(:css, 'body').click
-        expect(session).to have_selector(:css, '.change_event_triggered', match: :one)
+        expect(session).to have_selector(:css, '.change_event_triggered', visible: :all, match: :one)
       end
     end
 
@@ -135,7 +135,7 @@
                         fill_options: { clear: :backspace })
         # click outside the field to trigger the change event
         session.find(:css, '#with_focus_event').click
-        expect(session).to have_selector(:css, '.change_event_triggered', match: :one, wait: 5)
+        expect(session).to have_selector(:css, '.change_event_triggered', visible: :all, match: :one, wait: 5)
       end
 
       it 'should trigger input event field_value.length times' do
@@ -146,7 +146,7 @@
         # click outside the field to trigger the change event
         # session.find(:css, 'body').click
         session.find(:css, 'h1', text: 'FooBar').click
-        expect(session).to have_xpath('//p[@class="input_event_triggered"]', count: 13)
+        expect(session).to have_xpath('//p[@class="input_event_triggered"]', count: 13, visible: :all)
       end
     end