Fix invalid HTML generated by AnimationDisabler #2498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The W3C Validator was reporting an error: > Element style not allowed as child of element body in this context. > > Contexts in which element style may be used: > Where metadata content is expected. > In a noscript element that is a child of a head element. > Content model for element body: > Flow content. It looks like there can't be any <style> tags inside the <body> element [1]. The <script> part of the markup template remains at the end of the <body> element because it only makes sense if jQuery has already been defined, and jQuery could be defined anywhere inside the <head> or <body> elements. [1] https://html.spec.whatwg.org/multipage/semantics.html#the-style-element
|
Thanks for this --- While <style> tags are technically illegal outside the element, all modern browsers support it. That said, I don't think it will hurt anything to make it technically legal - just want to think about any possible ramifications for a few days --- If I don't come up with any will merge by end of week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was experimenting with the W3C rspec validations gem, it reported all pages had invalid HTML due to the contents added by Capybara's AnimationDisabler. The W3C Validator was reporting an error:
It looks like there can't be any style tags inside the body element.
The
<script>part of the markup template remains at the end of the<body>element because it only makes sense if jQuery has already been defined, and jQuery could be defined anywhere inside the<head>or<body>elements.I'm not familiar with your source code at all, so comments about either the implementation or the tests are much appreciated 🙏.