Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiplatform docker #416

Merged
merged 4 commits into from
Nov 28, 2022
Merged

Conversation

hilli
Copy link
Contributor

@hilli hilli commented Nov 28, 2022

Description

I am doing development on an Apple Silicon Mac and doing deploys to other ARM based hosts. I have previously build the images myself, but figured that I can't be the only one who would like hanko on more than one architecture.

Implementation

  • Added parameter in the Dockerfile's to enable building for multiple architectures
    • Fixing the builder to the BUILDPLATFORM
    • Utilizing GOs crossplatform builder to target TARGETARCH
    • Let buildx handle the matrix (1x2, but not the less :)) from there
  • Bumped Docker's Github Actions versions to get rid of warnings, hopefully
  • Bumped the go version to 1.19 in the Dockerfile

Tests

Try running the action related to the workflow on this branch. There should be bulds for both amd64 and arm64 on ghcr.io afterwards.

Todos

There are other architectures available (linux/riscv64, linux/ppc64le, linux/s390x, linux/386, linux/mips64le, linux/mips64, linux/arm/v7, linux/arm/v6), which could be added to the matrix, but I would wait with that until there is a need for it.

@like-a-bause
Copy link
Contributor

Hi hilli! Thanks for the contribution. Super cool.

Copy link
Contributor

@like-a-bause like-a-bause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks a lot!

@like-a-bause like-a-bause merged commit 0964369 into teamhanko:main Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants