Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't check image access on ecr or gcr #101

Closed
wants to merge 1 commit into from

Conversation

jag0k
Copy link

@jag0k jag0k commented May 31, 2019

If your change requires any additions or changes to the documentation or to the end-to-end test suite, please submit them as 1 or more pull requests against that repo and refer to them here.

requires deis/workflow#1234
requires deis/workflow-e2e#5678

@jag0k jag0k force-pushed the no_image_access_check_ECR_GCR branch from b4f82aa to 3a6e36f Compare May 31, 2019 06:07
@jag0k jag0k closed this May 31, 2019
@jag0k jag0k deleted the no_image_access_check_ECR_GCR branch May 31, 2019 06:14
@Cryptophobia
Copy link
Member

Per the CI reported error just add a whitespace and the python linting should pass:

elif settings.REGISTRY_LOCATION != 'ecr':

@Cryptophobia
Copy link
Member

@duanhongyi do you know if your PR here #90 could have affected this image access check for ECR. @jag0k is reporting problems with ECR registry and registry-secret.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants