[GUILD] Typescript Button #2123

driesd · 2022-05-10T13:54:30Z

This PR converts the Button component to TypeScript. It also gets rid of the auto blur functionality.

src/components/button/Button.tsx

driesd added 2 commits May 10, 2022 15:27

Just pass the ref instead of doing the auto blur magic

37da887

Convert component to TypeScript

fbd7ace

driesd self-assigned this May 10, 2022

driesd added WIP maintenance labels May 10, 2022

driesd added 4 commits May 10, 2022 16:02

Pass the props directly to the Box

d0ac866

Make level prop optional as we provide a default value

0c0c210

Convert stories to TypeScript

a0070c2

Declare module @teamleader/ui-icons

186b0ec

driesd added ready and removed WIP labels May 10, 2022

Linting

16af5c6

lowiebenoot reviewed May 11, 2022

View reviewed changes

src/components/button/Button.tsx Outdated Show resolved Hide resolved

src/components/button/Button.tsx Outdated Show resolved Hide resolved

driesd and others added 4 commits May 11, 2022 11:47

Rename Props to ButtonProps

30cd0b7

Extend interface with BoxProps and omit props size

1ec69c8

♻️ Export Box props so they can be inherited

9be9cc5

Cast enum so we can use string literals

09736a5

driesd requested review from lowiebenoot, BeirlaenAaron and jelledc May 11, 2022 09:57

lowiebenoot approved these changes May 12, 2022

View reviewed changes

BeirlaenAaron approved these changes May 12, 2022

View reviewed changes

driesd merged commit 988fa70 into next-release May 16, 2022

driesd deleted the guild/typescript-button branch May 16, 2022 07:56

lorgan3 mentioned this pull request Nov 15, 2022

Bring back button blur #2445

Merged

Provide feedback