Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

[FRAF-544] Flex component #2185

Merged
merged 19 commits into from
Jun 1, 2022
Merged

Conversation

farazatarodi
Copy link
Collaborator

Link to issue

Jira

Description

Adds a Flex component to the UI library that will be used for layouts. For the full information and the properties, check the Jira ticket.

Manual check

Check the storybook.

src/components/flex/Flex.tsx Outdated Show resolved Hide resolved
src/components/flex/Flex.tsx Outdated Show resolved Hide resolved
@farazatarodi farazatarodi requested review from lorgan3 and qubis741 June 1, 2022 09:32
@farazatarodi farazatarodi requested a review from ArnaudWeyts June 1, 2022 10:01
@farazatarodi farazatarodi removed the hold label Jun 1, 2022
Copy link
Collaborator

@lowiebenoot lowiebenoot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't all flex props be optional?

@farazatarodi
Copy link
Collaborator Author

Shouldn't all flex props be optional?

@lowiebenoot aren't they now?

@lowiebenoot
Copy link
Collaborator

@farazatarodi ah, didn't see the Partial 🙈

lowiebenoot
lowiebenoot previously approved these changes Jun 1, 2022
qubis741
qubis741 previously approved these changes Jun 1, 2022
JorenSaeyTL
JorenSaeyTL previously approved these changes Jun 1, 2022
@JorenSaeyTL
Copy link
Contributor

MCing ⌛ ...

@JorenSaeyTL
Copy link
Contributor

MCed ✅

Copy link
Contributor

@ArnaudWeyts ArnaudWeyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still missing a changelog entry

@farazatarodi farazatarodi merged commit d739ff7 into next-release Jun 1, 2022
@farazatarodi farazatarodi deleted the FRAF-544-Flex-component branch June 1, 2022 15:09
@farazatarodi farazatarodi mentioned this pull request Jun 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants