This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farazatarodi
requested review from
ArnaudWeyts,
BeirlaenAaron,
driesd,
eniskraasniqi1,
jelledc,
lowiebenoot,
qubis741 and
stefaandevylder
May 31, 2022 21:06
qubis741
reviewed
Jun 1, 2022
lorgan3
reviewed
Jun 1, 2022
lowiebenoot
reviewed
Jun 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't all flex props be optional?
@lowiebenoot aren't they now? |
@farazatarodi ah, didn't see the |
lowiebenoot
previously approved these changes
Jun 1, 2022
qubis741
previously approved these changes
Jun 1, 2022
JorenSaeyTL
previously approved these changes
Jun 1, 2022
MCing ⌛ ... |
MCed ✅ |
ArnaudWeyts
approved these changes
Jun 1, 2022
ArnaudWeyts
suggested changes
Jun 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still missing a changelog entry
farazatarodi
dismissed stale reviews from JorenSaeyTL, qubis741, and lowiebenoot
via
June 1, 2022 13:51
179eb9f
farazatarodi
requested review from
ArnaudWeyts,
lowiebenoot,
qubis741 and
JorenSaeyTL
June 1, 2022 13:52
ArnaudWeyts
approved these changes
Jun 1, 2022
qubis741
approved these changes
Jun 1, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
Jira
Description
Adds a Flex component to the UI library that will be used for layouts. For the full information and the properties, check the Jira ticket.
Manual check
Check the storybook.