This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Moving back the input props passed on Input #2285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eniskraasniqi1
requested review from
lowiebenoot,
lorgan3,
driesd,
qubis741 and
farazatarodi
qubis741
approved these changes
Jul 15, 2022
jelledc
approved these changes
Jul 15, 2022
lorgan3
approved these changes
Jul 15, 2022
|
Manually checked ✅ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This was in JS before.
These two functions will never be called if the props are there,
handleInputFocusandhandleInputClick, which have been created to handle the onFocus and onClick(props) inside these two functions.Now when focussing a field its not possible to do something else, and also we're having this bug. This PR fixes it, and also works as intended.