This repository was archived by the owner on Feb 1, 2024. It is now read-only.
[FRAF-873] - Pass onClick to the wrapper of checkbox #2314
Merged
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eniskraasniqi1
requested review from
BeirlaenAaron,
driesd,
farazatarodi,
jelledc,
JorenSaeyTL,
KristofColpaert,
lorgan3,
lowiebenoot and
qubis741
lowiebenoot
approved these changes
Aug 8, 2022
JorenSaeyTL
approved these changes
Aug 8, 2022
|
MC ok |
qubis741
approved these changes
Aug 8, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using checkbox on a Datagrid Row, currently when clicking the checkbox triggers the row to be clicked also.
This is happening because we're not passing the onClick to the container, so when trying stopPropagation it does nothing.
Manual check