This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Fix close button alignment issue #2351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorgan3
requested review from
lowiebenoot,
jelledc,
KristofColpaert,
driesd,
qubis741,
stefaandevylder,
eniskraasniqi1,
BeirlaenAaron,
JorenSaeyTL and
farazatarodi
qubis741
previously approved these changes
Sep 9, 2022
JorenSaeyTL
previously approved these changes
Sep 9, 2022
jelledc
previously approved these changes
Sep 9, 2022
farazatarodi
previously approved these changes
Sep 9, 2022
BeirlaenAaron
previously approved these changes
Sep 9, 2022
stefaandevylder
previously approved these changes
Sep 9, 2022
lowiebenoot
previously approved these changes
Sep 12, 2022
|
I'll have to add a changelog entry after all because I want to create a release with this fix soon 😅 |
lorgan3
dismissed stale reviews from lowiebenoot, stefaandevylder, BeirlaenAaron, farazatarodi, jelledc, JorenSaeyTL, and qubis741
via
7741d2f
eniskraasniqi1
approved these changes
Sep 12, 2022
qubis741
approved these changes
Sep 12, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make the close-button css more specific in order to solve an issue that the transformed css is not in the same order as in development.
Doesn't seem like this requires a changelog entry since I think this is coupled to our build process in core but happy to add one if necessary.
Sharing before and after screenshot in a google doc in case this contains info that shouldn't be public yet
https://docs.google.com/document/d/1B8PC6TQWwYPaxgWwpn3X7QRabuLdqTy-nJkHo6QaOKA/edit?usp=sharing