This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Fix dialog being to big on Safari #2412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefaandevylder
requested review from
BeirlaenAaron,
eniskraasniqi1,
farazatarodi,
jelledc,
JorenSaeyTL,
KristofColpaert,
lorgan3 and
qubis741
lorgan3
approved these changes
Oct 26, 2022
eniskraasniqi1
approved these changes
Oct 26, 2022
BeirlaenAaron
approved these changes
Oct 27, 2022
qubis741
approved these changes
Oct 27, 2022
|
Manually checking ⌛ |
qubis741
approved these changes
Oct 27, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bug: When multiple tabs are open in safari, the save button of the new modal company add isn't visible.
This was semi-reproducible on Safari Macbook. It indeed cut off a part of the screen when opening a new tab.
The cause of the bug is because we are using
vhandvwas a measurelent in CSS. This type of measurement is differently calculated on WebKit.Screenshot before this PR
Screenshot after this PR