This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
[FRONT-125] Correct popover shadow and border #2708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there is no width and style set, so it doesn't have any effect. The border is actually set with a box-shadow.
We only have a specification for the neutral lightest, so keeping the other like it is already.
…changes the color of the border
lowiebenoot
requested review from
driesd,
qubis741,
eniskraasniqi1,
BeirlaenAaron and
JorenSaeyTL
qubis741
approved these changes
Jul 11, 2023
farazatarodi
approved these changes
Jul 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The popover shadow and border was not aligned with our design spec, so we fixed that.
The shadow had to be updated through
@teamleader/ui-utilities.