-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild bundle config #41
Draft
jdreesen
wants to merge
11
commits into
main
Choose a base branch
from
rebuild-config
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdreesen
force-pushed
the
rebuild-config
branch
from
February 6, 2023 22:39
024e57f
to
d5831fb
Compare
This was referenced Feb 6, 2023
Draft
mike4git
reviewed
Sep 6, 2023
mike4git
reviewed
Sep 6, 2023
…ta_converter.converters"
Co-authored-by: Michael Albrecht <m.albrecht@neusta.de>
…the generic converter factory
…the generic converter factory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I wanted to implement #39, I realized that the current bundle configuration does not really allow configuring different converter types (as already described in #40). It is possible to specify any converter class, but it must have the exact same constructor parameters as the class
GenericConverter
. This is not the case with theStrategicConverter
, so that the current configuration is not suitable for this type.Therefore, here is the proposal of an implementation that allows arbitrary converter types. Instead of defining the class, the type is now specified by means of a keyword and the corresponding configuration is nested underneath.
The advantage is that the configuration per type is freely definable. In addition, this allows the configuration to be extended by other bundles or the app.
Current:
Proposed:
However, it is not yet entirely clear how decorating converters fit into this scheme. Currently, only exactly one converter type keyword is allowed. One consideration would be to create a new interface for decorating converters and to allow several decorating converters in addition to the one main converter, like: