Migrate from pipenv to poetry #84

sayanarijit · 2020-02-20T12:53:48Z

Poetry concludes setup.py and Pipfile into a pyproject.toml file
in this repo.

Commit A

poetry.lock can be compared with Pipfile.lock. And poetry.toml
saves us from the need to export the PIPENV_VENV_IN_PROJECT env var.
Other config defaults can be defined here.

Watch A great talk on Python dependency management and poetry:
https://youtu.be/6ey-nNRvBrk

Commit B

Develop and build with nix, nixos.

Commit C

Use Nix for CircleCI tests

Commit D

Improve getting started guide

Ref:

pyproject.toml

sayanarijit · 2020-02-20T13:14:50Z

Hmm review app is missing...

karantan · 2020-02-20T13:29:16Z

I would add shell.nix and use poetry inside nix. This setup is way more bulletproof because you don't need to use pyenv and/or any other things related to python.

sayanarijit · 2020-02-20T14:33:12Z

@karantan not sure if we should add nix in this project... Since it's meant to be an example pyramid app. @zupo should we?

Poetry concludes `setup.py` and `Pipfile` into a `pyproject.toml` file in this repo. `poetry.lock` can be compared with `Pipfile.lock`. And `poetry.toml` saves us from the need to export the `PIPENV_VENV_IN_PROJECT` env var. Other config defaults can be defined here. Watch A great talk on Python dependency management and poetry: https://youtu.be/6ey-nNRvBrk Ref: #83

zupo · 2020-03-02T16:14:20Z

.circleci/config.yml

+      - Checkout
+      - Backend Deps:
+          requires:
+            - Checkout


Checkout and Backend Deps can probably be merged into a single job, saves time on cache upload/download.

Moreover, we don't need separate jobs here. The steps are fast enough to run them in a single job.

zupo

General direction very good, some final polish needed.

zupo · 2020-03-02T16:54:04Z

@sayanarijit: I can't make install on my local machine. Seen this before? Any idea what it is?

➜  pyramid-realworld-example-app git:(migrate/migrate-to-poetry-1251) ✗ make install
make[1]: Entering directory '/Users/zupo/work/pyramid-realworld-example-app'
pyproject.toml/poetry.lock is newer than .installed, (re)installing
Creating virtualenv conduit in /Users/zupo/work/pyramid-realworld-example-app/.venv
Installing dependencies from lock file


Package operations: 144 installs, 0 updates, 0 removals

  - Installing six (1.14.0)
  - Installing attrs (19.3.0)
  - Installing pastedeploy (2.1.0)
  - Installing plaster (1.0)
  - Installing pyrsistent (0.15.7)
  - Installing hupper (1.10.1)
  - Installing jsonschema (3.2.0)
  - Installing markupsafe (1.1.1)
  - Installing plaster-pastedeploy (0.7)
  - Installing pyparsing (2.4.6)
  - Installing pyyaml (5.3)
  - Installing smmap2 (2.0.5)
  - Installing soupsieve (1.9.5)
  - Installing translationstring (1.3)
  - Installing venusian (3.0.0)
  - Installing webob (1.8.6)
  - Installing zope.deprecation (4.4.0)
  - Installing zope.interface (4.7.1)
  - Installing appdirs (1.4.3)
  - Installing backports.functools-lru-cache (1.6.1)
  - Installing backports.functools-partialmethod (3.5.1.0)
  - Installing beautifulsoup4 (4.8.2)
  - Installing certifi (2019.11.28)
  - Installing chardet (3.0.4)
  - Installing colorama (0.4.3)
  - Installing cssselect (1.1.0)
  - Installing distlib (0.3.0)
  - Installing entrypoints (0.3)
  - Installing enum34 (1.1.6)
  - Installing filelock (3.0.12)
  - Installing gitdb2 (3.0.2)
  - Installing idna (2.9)
  - Installing lazy-object-proxy (1.4.3)

[EnvCommandError]
Command ['/Users/zupo/work/pyramid-realworld-example-app/.venv/bin/pip', 'install', '--no-deps', 'lazy-object-proxy==1.4.3'] errored with the following return code 1, and output: 
Collecting lazy-object-proxy==1.4.3
  Using cached https://files.pythonhosted.org/packages/07/3f/a3d687f83c7d44970f70ff0400677746c8860b11f0c08f6b4e07205f0cdc/lazy-object-proxy-1.4.3.tar.gz
  Installing build dependencies: started
  Installing build dependencies: finished with status 'error'
  ERROR: Command errored out with exit status 1:
   command: /Users/zupo/work/pyramid-realworld-example-app/.venv/bin/python3.8 /Users/zupo/work/pyramid-realworld-example-app/.venv/lib/python3.8/site-packages/pip install --ignore-installed --no-user --prefix /private/var/folders/ck/dlscb24n4lzdlzpt3w0pdcgh0000gn/T/pip-build-env-ur37pa6_/overlay --no-warn-script-location --no-binary :none: --only-binary :none: -i https://pypi.org/simple -- 'setuptools>=30.3.0' wheel 'setuptools_scm>=3.3.1'
       cwd: None
  Complete output (14 lines):
  Traceback (most recent call last):
    File "/nix/store/1g6a021xk5wlx1sz0qg9y4ahq6vfz5wn-python3-3.8.1/lib/python3.8/runpy.py", line 193, in _run_module_as_main
      return _run_code(code, main_globals, None,
    File "/nix/store/1g6a021xk5wlx1sz0qg9y4ahq6vfz5wn-python3-3.8.1/lib/python3.8/runpy.py", line 86, in _run_code
      exec(code, run_globals)
    File "/Users/zupo/work/pyramid-realworld-example-app/.venv/lib/python3.8/site-packages/pip/__main__.py", line 16, in <module>
      from pip._internal import main as _main  # isort:skip # noqa
    File "/Users/zupo/work/pyramid-realworld-example-app/.venv/lib/python3.8/site-packages/pip/_internal/__init__.py", line 4, in <module>
      import locale
    File "/nix/store/1g6a021xk5wlx1sz0qg9y4ahq6vfz5wn-python3-3.8.1/lib/python3.8/locale.py", line 16, in <module>
      import re
    File "/nix/store/1g6a021xk5wlx1sz0qg9y4ahq6vfz5wn-python3-3.8.1/lib/python3.8/re.py", line 143, in <module>
      class RegexFlag(enum.IntFlag):
  AttributeError: module 'enum' has no attribute 'IntFlag'
  ----------------------------------------
ERROR: Command errored out with exit status 1: /Users/zupo/work/pyramid-realworld-example-app/.venv/bin/python3.8 /Users/zupo/work/pyramid-realworld-example-app/.venv/lib/python3.8/site-packages/pip install --ignore-installed --no-user --prefix /private/var/folders/ck/dlscb24n4lzdlzpt3w0pdcgh0000gn/T/pip-build-env-ur37pa6_/overlay --no-warn-script-location --no-binary :none: --only-binary :none: -i https://pypi.org/simple -- 'setuptools>=30.3.0' wheel 'setuptools_scm>=3.3.1' Check the logs for full command output.
WARNING: You are using pip version 19.2.3, however version 20.0.2 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.

make[1]: *** [Makefile:14: .installed] Error 1
make[1]: Leaving directory '/Users/zupo/work/pyramid-realworld-example-app'
make: *** [Makefile:10: install] Error 2

zupo · 2020-03-02T16:54:21Z

@infinisil: ^^

zupo · 2020-03-02T17:07:10Z

Resolved the AttributeError: module 'enum' has no attribute 'IntFlag' error by manually removing erroneous dependencies from poetry.lock, exactly like in https://github.com/niteoweb/kai-app/commit/fc375dd5d036c901d20267f364ef129028cd47f1#diff-c1455f896a7a8ad0ec7026e533f55744 (reason: python-poetry/poetry#844 (comment)).

Now I have another error:

➜  pyramid-realworld-example-app git:(migrate/migrate-to-poetry-1251) ✗ make install
make[1]: Entering directory '/Users/zupo/work/pyramid-realworld-example-app'
pyproject.toml/poetry.lock is newer than .installed, (re)installing
Creating virtualenv conduit in /Users/zupo/work/pyramid-realworld-example-app/.venv
Installing dependencies from lock file


Package operations: 141 installs, 0 updates, 0 removals

  - Installing six (1.14.0)
  - Installing attrs (19.3.0)
  - Installing pastedeploy (2.1.0)
  - Installing plaster (1.0)
  - Installing pyrsistent (0.15.7)
  - Installing hupper (1.10.1)
  - Installing jsonschema (3.2.0)
  - Installing markupsafe (1.1.1)
  - Installing plaster-pastedeploy (0.7)
  - Installing pyparsing (2.4.6)
  - Installing pyyaml (5.3)
  - Installing smmap2 (2.0.5)
  - Installing soupsieve (1.9.5)
  - Installing translationstring (1.3)
  - Installing venusian (3.0.0)
  - Installing webob (1.8.6)
  - Installing zope.deprecation (4.4.0)
  - Installing zope.interface (4.7.1)
  - Installing appdirs (1.4.3)
  - Installing beautifulsoup4 (4.8.2)
  - Installing certifi (2019.11.28)
  - Installing chardet (3.0.4)
  - Installing colorama (0.4.3)
  - Installing cssselect (1.1.0)
  - Installing distlib (0.3.0)
  - Installing entrypoints (0.3)
  - Installing filelock (3.0.12)
  - Installing gitdb2 (3.0.2)
  - Installing idna (2.9)
  - Installing lazy-object-proxy (1.4.3)

[EnvCommandError]
Command ['/Users/zupo/work/pyramid-realworld-example-app/.venv/bin/pip', 'install', '--no-deps', 'lazy-object-proxy==1.4.3'] errored with the following return code 1, and output: 
Collecting lazy-object-proxy==1.4.3
  Using cached https://files.pythonhosted.org/packages/07/3f/a3d687f83c7d44970f70ff0400677746c8860b11f0c08f6b4e07205f0cdc/lazy-object-proxy-1.4.3.tar.gz
  Installing build dependencies: started
  Installing build dependencies: finished with status 'done'
  Getting requirements to build wheel: started
  Getting requirements to build wheel: finished with status 'done'
    Preparing wheel metadata: started
    Preparing wheel metadata: finished with status 'done'
Building wheels for collected packages: lazy-object-proxy
  Building wheel for lazy-object-proxy (PEP 517): started
  Building wheel for lazy-object-proxy (PEP 517): finished with status 'error'
  ERROR: Command errored out with exit status 1:
   command: /Users/zupo/work/pyramid-realworld-example-app/.venv/bin/python3.8 /Users/zupo/work/pyramid-realworld-example-app/.venv/lib/python3.8/site-packages/pip/_vendor/pep517/_in_process.py build_wheel /var/folders/ck/dlscb24n4lzdlzpt3w0pdcgh0000gn/T/tmpn_dd2qp7
       cwd: /private/var/folders/ck/dlscb24n4lzdlzpt3w0pdcgh0000gn/T/pip-install-9munczuo/lazy-object-proxy
  Complete output (102 lines):
  running bdist_wheel
  running build
  running build_py
  creating build
  creating build/lib.macosx-10.6-x86_64-3.8
  creating build/lib.macosx-10.6-x86_64-3.8/lazy_object_proxy
  copying src/lazy_object_proxy/compat.py -> build/lib.macosx-10.6-x86_64-3.8/lazy_object_proxy
  copying src/lazy_object_proxy/_version.py -> build/lib.macosx-10.6-x86_64-3.8/lazy_object_proxy
  copying src/lazy_object_proxy/slots.py -> build/lib.macosx-10.6-x86_64-3.8/lazy_object_proxy
  copying src/lazy_object_proxy/__init__.py -> build/lib.macosx-10.6-x86_64-3.8/lazy_object_proxy
  copying src/lazy_object_proxy/utils.py -> build/lib.macosx-10.6-x86_64-3.8/lazy_object_proxy
  copying src/lazy_object_proxy/simple.py -> build/lib.macosx-10.6-x86_64-3.8/lazy_object_proxy
  running build_ext
  building 'lazy_object_proxy.cext' extension
  creating build/temp.macosx-10.6-x86_64-3.8
  creating build/temp.macosx-10.6-x86_64-3.8/src
  creating build/temp.macosx-10.6-x86_64-3.8/src/lazy_object_proxy
  clang -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O3 -Wall -Isrc/lazy_object_proxy -I/Users/zupo/work/pyramid-realworld-example-app/.venv/include -I/nix/store/1g6a021xk5wlx1sz0qg9y4ahq6vfz5wn-python3-3.8.1/include/python3.8 -c src/lazy_object_proxy/cext.c -o build/temp.macosx-10.6-x86_64-3.8/src/lazy_object_proxy/cext.o
  clang-7: warning: argument unused during compilation: '-fno-strict-overflow' [-Wunused-command-line-argument]
  clang -bundle -undefined dynamic_lookup -L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-zlib-1.2.11/lib -L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-bzip2-1.0.6.0.1/lib -L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-expat-2.2.8/lib -L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-xz-5.2.4/lib -L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-libffi-3.3/lib -L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-gdbm-1.18.1/lib -L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-sqlite-3.31.0/lib -L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-readline-6.3p08/lib -L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-ncurses-6.1-20190112/lib -L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-openssl-1.1.1d/lib -L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-configd-osx-10.8.5/lib -L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-zlib-1.2.11/lib -L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-bzip2-1.0.6.0.1/lib -L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-expat-2.2.8/lib -L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-xz-5.2.4/lib -L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-libffi-3.3/lib -L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-gdbm-1.18.1/lib -L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-sqlite-3.31.0/lib -L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-readline-6.3p08/lib -L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-ncurses-6.1-20190112/lib -L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-openssl-1.1.1d/lib -L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-configd-osx-10.8.5/lib build/temp.macosx-10.6-x86_64-3.8/src/lazy_object_proxy/cext.o -L/nix/store/1g6a021xk5wlx1sz0qg9y4ahq6vfz5wn-python3-3.8.1/lib -o build/lib.macosx-10.6-x86_64-3.8/lazy_object_proxy/cext.cpython-38-darwin.so
  ld: warning: directory not found for option '-L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-zlib-1.2.11/lib'
  ld: warning: directory not found for option '-L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-bzip2-1.0.6.0.1/lib'
  ld: warning: directory not found for option '-L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-expat-2.2.8/lib'
  ld: warning: directory not found for option '-L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-xz-5.2.4/lib'
  ld: warning: directory not found for option '-L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-libffi-3.3/lib'
  ld: warning: directory not found for option '-L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-gdbm-1.18.1/lib'
  ld: warning: directory not found for option '-L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-sqlite-3.31.0/lib'
  ld: warning: directory not found for option '-L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-readline-6.3p08/lib'
  ld: warning: directory not found for option '-L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-ncurses-6.1-20190112/lib'
  ld: warning: directory not found for option '-L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-openssl-1.1.1d/lib'
  ld: warning: directory not found for option '-L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-configd-osx-10.8.5/lib'
  ld: warning: directory not found for option '-L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-zlib-1.2.11/lib'
  ld: warning: directory not found for option '-L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-bzip2-1.0.6.0.1/lib'
  ld: warning: directory not found for option '-L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-expat-2.2.8/lib'
  ld: warning: directory not found for option '-L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-xz-5.2.4/lib'
  ld: warning: directory not found for option '-L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-libffi-3.3/lib'
  ld: warning: directory not found for option '-L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-gdbm-1.18.1/lib'
  ld: warning: directory not found for option '-L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-sqlite-3.31.0/lib'
  ld: warning: directory not found for option '-L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-readline-6.3p08/lib'
  ld: warning: directory not found for option '-L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-ncurses-6.1-20190112/lib'
  ld: warning: directory not found for option '-L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-openssl-1.1.1d/lib'
  ld: warning: directory not found for option '-L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-configd-osx-10.8.5/lib'
  installing to build/bdist.macosx-10.6-x86_64/wheel
  running install
  running install_lib
  creating build/bdist.macosx-10.6-x86_64
  creating build/bdist.macosx-10.6-x86_64/wheel
  creating build/bdist.macosx-10.6-x86_64/wheel/lazy_object_proxy
  copying build/lib.macosx-10.6-x86_64-3.8/lazy_object_proxy/compat.py -> build/bdist.macosx-10.6-x86_64/wheel/lazy_object_proxy
  copying build/lib.macosx-10.6-x86_64-3.8/lazy_object_proxy/_version.py -> build/bdist.macosx-10.6-x86_64/wheel/lazy_object_proxy
  copying build/lib.macosx-10.6-x86_64-3.8/lazy_object_proxy/slots.py -> build/bdist.macosx-10.6-x86_64/wheel/lazy_object_proxy
  copying build/lib.macosx-10.6-x86_64-3.8/lazy_object_proxy/__init__.py -> build/bdist.macosx-10.6-x86_64/wheel/lazy_object_proxy
  copying build/lib.macosx-10.6-x86_64-3.8/lazy_object_proxy/utils.py -> build/bdist.macosx-10.6-x86_64/wheel/lazy_object_proxy
  copying build/lib.macosx-10.6-x86_64-3.8/lazy_object_proxy/cext.cpython-38-darwin.so -> build/bdist.macosx-10.6-x86_64/wheel/lazy_object_proxy
  copying build/lib.macosx-10.6-x86_64-3.8/lazy_object_proxy/simple.py -> build/bdist.macosx-10.6-x86_64/wheel/lazy_object_proxy
  running install_egg_info
  running egg_info
  writing src/lazy_object_proxy.egg-info/PKG-INFO
  writing dependency_links to src/lazy_object_proxy.egg-info/dependency_links.txt
  writing top-level names to src/lazy_object_proxy.egg-info/top_level.txt
  reading manifest file 'src/lazy_object_proxy.egg-info/SOURCES.txt'
  writing manifest file 'src/lazy_object_proxy.egg-info/SOURCES.txt'
  Copying src/lazy_object_proxy.egg-info to build/bdist.macosx-10.6-x86_64/wheel/lazy_object_proxy-1.4.3-py3.8.egg-info
  running install_scripts
  adding license file "LICENSE" (matched pattern "LICEN[CS]E*")
  adding license file "AUTHORS.rst" (matched pattern "AUTHORS*")
  creating build/bdist.macosx-10.6-x86_64/wheel/lazy_object_proxy-1.4.3.dist-info/WHEEL
  creating '/private/var/folders/ck/dlscb24n4lzdlzpt3w0pdcgh0000gn/T/pip-wheel-jl5bogr9/tmpop06r7gj/lazy_object_proxy-1.4.3-cp38-cp38-macosx_10_12_x86_64.whl' and adding 'build/bdist.macosx-10.6-x86_64/wheel' to it
  Traceback (most recent call last):
    File "/Users/zupo/work/pyramid-realworld-example-app/.venv/lib/python3.8/site-packages/pip/_vendor/pep517/_in_process.py", line 207, in <module>
      main()
    File "/Users/zupo/work/pyramid-realworld-example-app/.venv/lib/python3.8/site-packages/pip/_vendor/pep517/_in_process.py", line 197, in main
      json_out['return_val'] = hook(**hook_input['kwargs'])
    File "/Users/zupo/work/pyramid-realworld-example-app/.venv/lib/python3.8/site-packages/pip/_vendor/pep517/_in_process.py", line 140, in build_wheel
      return _build_backend().build_wheel(wheel_directory, config_settings,
    File "/private/var/folders/ck/dlscb24n4lzdlzpt3w0pdcgh0000gn/T/pip-build-env-gocgpive/overlay/lib/python3.8/site-packages/setuptools/build_meta.py", line 212, in build_wheel
      return self._build_with_temp_dir(['bdist_wheel'], '.whl',
    File "/private/var/folders/ck/dlscb24n4lzdlzpt3w0pdcgh0000gn/T/pip-build-env-gocgpive/overlay/lib/python3.8/site-packages/setuptools/build_meta.py", line 198, in _build_with_temp_dir
      self.run_setup()
    File "/private/var/folders/ck/dlscb24n4lzdlzpt3w0pdcgh0000gn/T/pip-build-env-gocgpive/overlay/lib/python3.8/site-packages/setuptools/build_meta.py", line 249, in run_setup
      super(_BuildMetaLegacyBackend,
    File "/private/var/folders/ck/dlscb24n4lzdlzpt3w0pdcgh0000gn/T/pip-build-env-gocgpive/overlay/lib/python3.8/site-packages/setuptools/build_meta.py", line 143, in run_setup
      exec(compile(code, __file__, 'exec'), locals())
    File "setup.py", line 61, in <module>
      setup(
    File "/private/var/folders/ck/dlscb24n4lzdlzpt3w0pdcgh0000gn/T/pip-build-env-gocgpive/overlay/lib/python3.8/site-packages/setuptools/__init__.py", line 144, in setup
      return distutils.core.setup(**attrs)
    File "/nix/store/1g6a021xk5wlx1sz0qg9y4ahq6vfz5wn-python3-3.8.1/lib/python3.8/distutils/core.py", line 148, in setup
      dist.run_commands()
    File "/nix/store/1g6a021xk5wlx1sz0qg9y4ahq6vfz5wn-python3-3.8.1/lib/python3.8/distutils/dist.py", line 966, in run_commands
      self.run_command(cmd)
    File "/nix/store/1g6a021xk5wlx1sz0qg9y4ahq6vfz5wn-python3-3.8.1/lib/python3.8/distutils/dist.py", line 985, in run_command
      cmd_obj.run()
    File "/private/var/folders/ck/dlscb24n4lzdlzpt3w0pdcgh0000gn/T/pip-build-env-gocgpive/overlay/lib/python3.8/site-packages/wheel/bdist_wheel.py", line 285, in run
      wf.write_files(archive_root)
    File "/private/var/folders/ck/dlscb24n4lzdlzpt3w0pdcgh0000gn/T/pip-build-env-gocgpive/overlay/lib/python3.8/site-packages/wheel/wheelfile.py", line 124, in write_files
      self.write(path, arcname)
    File "/private/var/folders/ck/dlscb24n4lzdlzpt3w0pdcgh0000gn/T/pip-build-env-gocgpive/overlay/lib/python3.8/site-packages/wheel/wheelfile.py", line 135, in write
      zinfo = ZipInfo(arcname or filename, date_time=get_zipinfo_datetime(st.st_mtime))
    File "/nix/store/1g6a021xk5wlx1sz0qg9y4ahq6vfz5wn-python3-3.8.1/lib/python3.8/zipfile.py", line 360, in __init__
      raise ValueError('ZIP does not support timestamps before 1980')
  ValueError: ZIP does not support timestamps before 1980
  ----------------------------------------
  ERROR: Failed building wheel for lazy-object-proxy
  Running setup.py clean for lazy-object-proxy
Failed to build lazy-object-proxy
ERROR: Could not build wheels for lazy-object-proxy which use PEP 517 and cannot be installed directly
WARNING: You are using pip version 19.2.3, however version 20.0.2 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.

make[1]: *** [Makefile:14: .installed] Error 1
make[1]: Leaving directory '/Users/zupo/work/pyramid-realworld-example-app'
make: *** [Makefile:10: install] Error 2

zupo · 2020-03-02T21:19:19Z

Resolved nix/poetry error above: f42145e

And now hitting yet another error, this time with Docker:

➜  pyramid-realworld-example-app git:(migrate/migrate-to-poetry-1251) ✗ make pgsql                         
Error response from daemon: No such container: pgsql
Error: No such container: pgsql
Error: Database is uninitialized and superuser password is not specified.
       You must specify POSTGRES_PASSWORD to a non-empty value for the
       superuser. For example, "-e POSTGRES_PASSWORD=password" on "docker run".

       You may also use "POSTGRES_HOST_AUTH_METHOD=trust" to allow all
       connections without a password. This is *not* recommended.

       See PostgreSQL documentation about "trust":
       https://www.postgresql.org/docs/current/auth-trust.html
make: *** [Makefile:25: pgsql] Error 1

@sayanarijit: make pgsql works for you? Seen this error before?

Docker 12 made it compulsory to pass DB password. Temporarily rolling back to 11.2.

sayanarijit · 2020-03-03T06:55:56Z

Found it... This is postgres-12 specific. It's now compulsory to specify postgresql password. Rolling back to v11. I'll deal with it when working on #72 as this PR is already big enough.

Merge Checkout and backend Deps into one job for performance and simplicity.

zupo · 2020-03-03T12:12:05Z

readme.md

- [Node(js)](https://nodejs.org) & [jq](https://github.com/stedolan/jq) (to run postman tests)
+- [node](https://nodejs.org) & [jq](https://github.com/stedolan/jq) (to run postman tests)
+
+If you have any dependency related issue, check out `./shell.nix` for the specific version of dependencies.


Good enough!

zupo · 2020-03-03T12:15:53Z

Circle CI is green, manual test of review app is good.

sayanarijit force-pushed the migrate/migrate-to-poetry-1251 branch from 15d6727 to 85103cc Compare February 20, 2020 12:57

sayanarijit commented Feb 20, 2020

View reviewed changes

pyproject.toml Show resolved Hide resolved

sayanarijit requested a review from zupo February 20, 2020 13:01

sayanarijit force-pushed the migrate/migrate-to-poetry-1251 branch 5 times, most recently from b97aebe to 948f60f Compare February 20, 2020 15:15

zupo temporarily deployed to pyramid-real-migrate-mi-yens59 February 20, 2020 15:15 Inactive

zupo had a problem deploying to pyramid-realworld-pr-84 February 20, 2020 15:15 Failure

sayanarijit force-pushed the migrate/migrate-to-poetry-1251 branch from 948f60f to 0d9cfc5 Compare February 20, 2020 15:20

zupo temporarily deployed to pyramid-real-migrate-mi-jbxue4 February 20, 2020 15:20 Inactive

zupo had a problem deploying to pyramid-realworld-pr-84 February 20, 2020 15:20 Failure

sayanarijit force-pushed the migrate/migrate-to-poetry-1251 branch from 0d9cfc5 to accfe83 Compare February 20, 2020 15:23

zupo temporarily deployed to pyramid-real-migrate-mi-xrtdvn February 20, 2020 15:23 Inactive

zupo had a problem deploying to pyramid-realworld-pr-84 February 20, 2020 15:23 Failure

sayanarijit force-pushed the migrate/migrate-to-poetry-1251 branch 4 times, most recently from 08dd84a to 7751c5a Compare February 20, 2020 15:44

zupo temporarily deployed to pyramid-real-migrate-mi-tvm5sd February 20, 2020 15:44 Inactive

zupo had a problem deploying to pyramid-realworld-pr-84 February 20, 2020 15:44 Failure

sayanarijit force-pushed the migrate/migrate-to-poetry-1251 branch from 7751c5a to 5456e94 Compare February 20, 2020 15:47

zupo deployed to pyramid-real-migrate-mi-pjasrr February 20, 2020 15:47 View deployment

zupo temporarily deployed to pyramid-realworld-pr-84 February 20, 2020 15:47 Inactive

sayanarijit force-pushed the migrate/migrate-to-poetry-1251 branch from 5456e94 to 2e4bff9 Compare February 20, 2020 15:51

zupo reviewed Mar 2, 2020

View reviewed changes

zupo requested changes Mar 2, 2020

View reviewed changes

zupo added 2 commits March 2, 2020 21:16

Manually remove enum34 as a dependency

816c31e

support building wheels

f42145e

zupo had a problem deploying to pyramid-realworld-pr-84 March 2, 2020 21:18 Failure

zupo temporarily deployed to pyramid-real-migrate-mi-7rkrnw March 2, 2020 21:18 Inactive

Fix make pgsql

603fcfe

Docker 12 made it compulsory to pass DB password. Temporarily rolling back to 11.2.

sayanarijit temporarily deployed to pyramid-real-migrate-mi-7rkrnw March 3, 2020 06:51 Inactive

sayanarijit had a problem deploying to pyramid-realworld-pr-84 March 3, 2020 06:51 Failure

Improve circleci build

f95b78e

Merge Checkout and backend Deps into one job for performance and simplicity.

sayanarijit temporarily deployed to pyramid-real-migrate-mi-7rkrnw March 3, 2020 07:21 Inactive

sayanarijit had a problem deploying to pyramid-realworld-pr-84 March 3, 2020 07:21 Failure

sayanarijit temporarily deployed to pyramid-real-migrate-mi-7rkrnw March 3, 2020 07:38 Inactive

sayanarijit had a problem deploying to pyramid-realworld-pr-84 March 3, 2020 07:38 Failure

Specify Python version in README

d44c84f

sayanarijit force-pushed the migrate/migrate-to-poetry-1251 branch from 8268258 to d44c84f Compare March 3, 2020 07:43

sayanarijit had a problem deploying to pyramid-realworld-pr-84 March 3, 2020 07:43 Failure

sayanarijit temporarily deployed to pyramid-real-migrate-mi-7rkrnw March 3, 2020 07:43 Inactive

sayanarijit requested a review from zupo March 3, 2020 07:45

zupo reviewed Mar 3, 2020

View reviewed changes

zupo approved these changes Mar 3, 2020

View reviewed changes

sayanarijit merged commit ee5333b into master Mar 3, 2020

zupo mentioned this pull request Mar 3, 2020

Show how to convert from requirements.txt/Pipenv to Poetry python-poetry/poetry#1701

Closed

1 task

sayanarijit mentioned this pull request Mar 4, 2020

Try Poetry #83

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate from pipenv to poetry #84

Migrate from pipenv to poetry #84

sayanarijit commented Feb 20, 2020 •

edited by karantan

Loading

sayanarijit commented Feb 20, 2020

karantan commented Feb 20, 2020

sayanarijit commented Feb 20, 2020

zupo Mar 2, 2020

zupo Mar 2, 2020

sayanarijit Mar 3, 2020

zupo left a comment

zupo commented Mar 2, 2020 •

edited

Loading

zupo commented Mar 2, 2020

zupo commented Mar 2, 2020

zupo commented Mar 2, 2020

sayanarijit commented Mar 3, 2020

zupo Mar 3, 2020

zupo commented Mar 3, 2020

Migrate from pipenv to poetry #84

Migrate from pipenv to poetry #84

Conversation

sayanarijit commented Feb 20, 2020 • edited by karantan Loading

Commit A

Commit B

Commit C

Commit D

sayanarijit commented Feb 20, 2020

karantan commented Feb 20, 2020

sayanarijit commented Feb 20, 2020

zupo Mar 2, 2020

Choose a reason for hiding this comment

zupo Mar 2, 2020

Choose a reason for hiding this comment

sayanarijit Mar 3, 2020

Choose a reason for hiding this comment

zupo left a comment

Choose a reason for hiding this comment

zupo commented Mar 2, 2020 • edited Loading

zupo commented Mar 2, 2020

zupo commented Mar 2, 2020

zupo commented Mar 2, 2020

sayanarijit commented Mar 3, 2020

zupo Mar 3, 2020

Choose a reason for hiding this comment

zupo commented Mar 3, 2020

sayanarijit commented Feb 20, 2020 •

edited by karantan

Loading

zupo commented Mar 2, 2020 •

edited

Loading