Project Lifeguard blogpost #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Beanow
commented
Sep 17, 2019
Beanow
commented
|
I don't like the text over the image that has text in it. |
|
Me either. Though it is caused in the screenshot by having the tablet-ish 1024 width. And 1920 (1080p) |
|
I could switch it for the one I use later on.
|
|
That doesn't really address the concern I have. I would probably put a horizontal bar of a transparent gray behind the text. |
Co-authored-by: Daniel Thompson-Yvetot <35242872+nothingismagick@users.noreply.github.com>
|
Yeah, I think that this is the better approach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.